Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the necessary variables to configure OAuth2 Client #5967

Merged
merged 1 commit into from Sep 17, 2020

Conversation

Alec4r
Copy link
Contributor

@Alec4r Alec4r commented Aug 26, 2020

These changes fix the next two issues:

  • The login isn't working because some variables wasn't defined, so always the login redirect to http://127.0.0.1:8000, these variables were hardcoded in the file analytics_dashboard/settings/base.py

  • In the file /edx/etc/insights.yml the variabels are defined with the prefix "INSIGHTS_" and that isn't working because We are expecting the variables without the prefix.

reviewers:
@morenol

@openedx-webhooks
Copy link

Thanks for the pull request, @Alec4r! I've created OSPR-4922 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels Aug 26, 2020
Copy link
Contributor

@morenol morenol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think that we should add this to Juniper once this gets merged to master.

CC (@nedbat)

@nedbat
Copy link
Contributor

nedbat commented Aug 26, 2020

Ping me again when this merges.

@natabene
Copy link
Contributor

natabene commented Aug 26, 2020

@Alec4r Thank you for your contribution! I will line this up for our review.

@fredsmith fredsmith merged commit 87ef334 into openedx:master Sep 17, 2020
@openedx-webhooks
Copy link

@Alec4r 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@morenol
Copy link
Contributor

morenol commented Oct 30, 2020

Hi @nedbat, could we cherry-pick this into juniper.master?

@nedbat
Copy link
Contributor

nedbat commented Feb 23, 2021

Yikes! Somehow I missed this comment. Would it still be useful to have this in Juniper?

@morenol
Copy link
Contributor

morenol commented Feb 23, 2021

I think that it could be useful for the Juniper installations, but since that release is not longer supported we can just keep it without this change.

@morenol morenol deleted the dam/oauth2-client branch February 23, 2021 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants