New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the necessary variables to configure OAuth2 Client #5967
Conversation
Thanks for the pull request, @Alec4r! I've created OSPR-4922 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I think that we should add this to Juniper once this gets merged to master.
CC (@nedbat)
Ping me again when this merges. |
@Alec4r Thank you for your contribution! I will line this up for our review. |
@Alec4r 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Hi @nedbat, could we cherry-pick this into juniper.master? |
Yikes! Somehow I missed this comment. Would it still be useful to have this in Juniper? |
I think that it could be useful for the Juniper installations, but since that release is not longer supported we can just keep it without this change. |
These changes fix the next two issues:
The login isn't working because some variables wasn't defined, so always the login redirect to http://127.0.0.1:8000, these variables were hardcoded in the file analytics_dashboard/settings/base.py
In the file /edx/etc/insights.yml the variabels are defined with the prefix "INSIGHTS_" and that isn't working because We are expecting the variables without the prefix.
reviewers:
@morenol