Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paypal payment processor default configuration #2684

Open
wants to merge 1 commit into
base: master
from

Conversation

@regisb
Copy link

regisb commented Nov 12, 2019

The cancel_url configuration setting is not used by the paypal payment
processor in ecommerce. Instead, the payment processor uses the
cancel_checkout_path configuration parameter.

This error has been reported by two different users:
https://discuss.overhang.io/t/ecommerce-plugin-500-error-on-fresh-setup
https://openedx.slack.com/archives/C02SNA1U4/p1573488822105900?thread_ts=1573488555.104900&cid=C02SNA1U4

The proposed fix has worked in both cases.

The `cancel_url` configuration setting is not used by the paypal payment
processor in ecommerce. Instead, the payment processor uses the
`cancel_checkout_path` configuration parameter.

This error has been reported by two different users:
https://discuss.overhang.io/t/ecommerce-plugin-500-error-on-fresh-setup
https://openedx.slack.com/archives/C02SNA1U4/p1573488822105900?thread_ts=1573488555.104900&cid=C02SNA1U4

The proposed fix has worked in both cases.
@edx-webhook

This comment has been minimized.

Copy link

edx-webhook commented Nov 12, 2019

Thanks for the pull request, @regisb! I've created OSPR-3923 to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • edx-code email threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, our process documentation is here.

@natabene

This comment has been minimized.

Copy link
Member

natabene commented Nov 13, 2019

@regisb Thank you for your contribution. @emma-green Can you give this a look when you have a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.