Update CAT create/edit view to support creation and modification of credit courses #299
Conversation
rlucioni
force-pushed
the
renzo/credit-create-edit
branch
from
ae47250
to
5d36700
Compare
| viewClass = this.courseSeatViewMappings[seatType]; | ||
|
|
||
| if (viewClass && model) { | ||
| if (viewClass && seats.length >= 1) { |
There was a problem hiding this comment.
Nitpick: > 0 would mean you can reduce the code by 1 character
rlucioni
force-pushed
the
renzo/credit-create-edit
branch
11 times, most recently
from
1a3650f
to
21038ff
Compare
| /* istanbul ignore next */ | ||
| Backbone.Validation.bind(view, { | ||
| valid: function (view, attr) { | ||
| var $el = view.$('[name=' + attr + ']'), |
There was a problem hiding this comment.
Shouldn't this be
view.$el.find('[name=' + attr + ']'),
There was a problem hiding this comment.
_s.sprintf will help avoid bugs here.
rlucioni
force-pushed
the
renzo/credit-create-edit
branch
from
a0f113d
to
14d8c61
Compare
| course: this.course | ||
| }); | ||
|
|
||
| row.render(); |
There was a problem hiding this comment.
It looks like the rowView already calls this on initialize (https://github.com/edx/ecommerce/blob/renzo/credit-create-edit/ecommerce/static/js/views/course_seat_form_fields/credit_course_seat_form_field_row_view.js#L46)
There was a problem hiding this comment.
Whoops, missed that. rowView no longer does that.
rlucioni
force-pushed
the
renzo/credit-create-edit
branch
2 times, most recently
from
00673d2
to
2df855f
Compare
…redit courses XCOM-511
rlucioni
force-pushed
the
renzo/credit-create-edit
branch
from
2df855f
to
d7b1f73
Compare
|
@clintonb or @AlasdairSwan, any further comments? I've addressed everything up to this point. |
|
👍 |
|
@AlasdairSwan if you have further comments, let me know and I'll address them with a follow-up PR. |
Update CAT create/edit view to support creation and modification of credit courses
XCOM-511
@clintonb and @AlasdairSwan, this is still a WIP, but I'd appreciate an early look, if you have the time. I'm still trying to get the table validation to work properly, and I still need to write tests.