Change Theme & Color throughout the App #1486

farhan-arshad-dev · 2020-11-26T09:49:13Z

Description

Change Theme & Color throughout the App.

- LEARNER-7995

farhan-arshad-dev · 2020-11-26T09:51:59Z

I'll create new screenshots(for screenshots test cases) once the design approved by the design team.
cc @miankhalid @omerhabib26

omerhabib26

"Create my account" btn semi-bold
"Sign In" bold
POS text color change
Profile View "Account Settings" button border color
Edit Profile screen -> profile image border is bit thicker in iOS
Language & Country text visiblity is very low, we can use neutralXDark instead of neutralDark
About Me submit button text could be semi-bold
Home Screen -> ViewPager Tabs text color on selection/unSelection
Settings -> Allow Cellular popup description text-color
Resources Page of CourseDashboard -> Icons color is bit lighter
CourseDashboard screen -> unit block title is semi-bold in iOS
Video Subtitles unselected text is semi-bold/regular in iOS
Next/Previous btns on CourseUnit get semi-bold in enable state
Video Player setting btn open popup-> text color is difficult to read -> selecting anyoption opens the popup and it's text is also difficult to read
DiscussionScreen -> All button text should be semi-bold to parity with iOS (IMO text size should be increased)

  -> Read posts left drawable color should be bit light

  -> Some Readed posts text still seems to semi-bold sometimes

  -> PostScreen -> "votes", "follow", "Report" text color should be Info500(blue) (https://miro.com/app/board/9J_leHZFA0=/?moveToWidget=3074457351875175007&cot=14)

  -> Date of Post(Date below Post Author) should be bit light (Same on Add comment Screen)

  -> "This is visible to everyone" text color should be bit lighter

  -> Create post missing icons of types (Discussion,Question)

  -> "Create a new Post" disable state missing

Snackbar -> Use "Warning100" for background Ref Miraboard

omerhabib26 · 2020-11-27T13:49:20Z

OpenEdXMobile/res/values/styles.xml

        <item name="android:scaleType">centerCrop</item>
        <item name="android:background">@drawable/white_circle</item>
    </style>

    <style name="agreement_text_style">
-        <item name="android:color">@color/edx_brand_gray_base</item>
+        <item name="android:color">@color/neutralBlack</item>


color isn't reflecting on text we should change it to <item name="android:textColor">@color/neutralBlack</item>

omerhabib26 · 2020-11-27T15:20:56Z

OpenEdXMobile/res/values/styles.xml

@@ -433,6 +438,10 @@
        <item name="android:background">@drawable/edx_brand_single_state_button</item>
    </style>

+    <style name="edX.Widget.CreationRoundButtonLayout" parent="edX.Widget.CreationButtonLayout">
+        <item name="android:background">@drawable/edx_brand_single_state_round_button</item>


we should update the <style name="edX.Widget.CreationButton">
to <style name="edX.Widget.CreationButton" parent="semibold_white_text"> or we can add <item name="android:fontFamily">?attr/fontSemiBold</item> to make the button text semi-bold

farhan-arshad-dev · 2020-12-03T08:18:27Z

@omerhabib26 Ready for another pass.

omerhabib26

Everything seems fine only a few changes are required

"Allow Cellular Download" action btns text colors is bit lighter
"Looking for a new Challange?" text color is lighter on iOS -> discuss within team what should be the color of this string
Certificate earned view -> text size is bit smaller
"Add a comment" background is bit dark as compared to iOS
"Add comment" button disabled color is not reflecting as compared to iOS -> same scenerio with all buttons on the discussion page
In disable state button color should be lighter or have some alpha value
loader color in video player isn't visible

codecov · 2020-12-04T18:07:54Z

Codecov Report

Merging #1486 (4588977) into master (57d8088) will decrease coverage by 7.19%.
The diff coverage is 4.22%.

@@             Coverage Diff             @@
##             master   #1486      +/-   ##
===========================================
- Coverage     13.34%   6.14%   -7.20%     
+ Complexity      933     466     -467     
===========================================
  Files           532     532              
  Lines         22337   22348      +11     
  Branches       2634    2631       -3     
===========================================
- Hits           2981    1374    -1607     
- Misses        19008   20788    +1780     
+ Partials        348     186     -162

Impacted Files	Coverage Δ	Complexity Δ
...org/edx/mobile/discussion/DiscussionTextUtils.java	`0.00% <0.00%> (-55.69%)`	`0.00 <0.00> (-13.00)`
...n/java/org/edx/mobile/player/PlayerController.java	`22.65% <0.00%> (ø)`	`15.00 <0.00> (ø)`
...a/org/edx/mobile/profiles/UserProfileFragment.java	`0.00% <0.00%> (-52.35%)`	`0.00 <0.00> (-8.00)`
...bile/src/main/java/org/edx/mobile/util/UiUtil.java	`5.88% <0.00%> (-9.81%)`	`2.00 <0.00> (-1.00)`
...bile/view/CourseDiscussionPostsThreadFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...dx/mobile/view/CourseDiscussionTopicsFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../edx/mobile/view/CourseUnitNavigationActivity.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...org/edx/mobile/view/DiscussionAddPostFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...a/org/edx/mobile/view/EditUserProfileFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...a/org/edx/mobile/view/FormFieldSelectFragment.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
... and 146 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d8088...3afc0d6. Read the comment docs.

omerhabib26

Only minor changes are required, else good to go

omerhabib26 · 2020-12-07T15:44:06Z

OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/PopularSubjectsAdapter.java

@@ -8,6 +8,8 @@
 import android.view.View;
 import android.view.ViewGroup;

+import com.bumptech.glide.Glide;


Unused Import

omerhabib26 · 2020-12-07T15:44:32Z

OpenEdXMobile/src/main/java/org/edx/mobile/view/adapters/SubjectsAdapter.java

@@ -12,6 +12,9 @@
 import android.widget.Filter;
 import android.widget.Filterable;

+import com.bumptech.glide.Glide;


Unused imports

omerhabib26 · 2020-12-07T15:45:51Z

OpenEdXMobile/src/main/java/org/edx/mobile/view/MainDiscoveryFragment.java

@@ -17,6 +10,14 @@
 import android.widget.RadioButton;
 import android.widget.RadioGroup;

+import androidx.annotation.IdRes;


AutoAlignment, but we can skip this as code refectoring

Already align.

- LEARNER-8024 - Update color scheme throughout the app according to the new color paragon - Replace worldmap image on sign-in - Generate new Screenshots for screenshot test cases

omerhabib26

Please squash the commits before merge

Change colors scheme for discussion threads & registration screens

fa03a8e

- LEARNER-7995

farhan-arshad-dev requested review from omerhabib26 and miankhalid November 26, 2020 09:49

farhan-arshad-dev mentioned this pull request Nov 30, 2020

Change color scheme for discussion threads & registration screens #1480

Closed

omerhabib26 requested changes Nov 30, 2020

View reviewed changes

omerhabib26 requested changes Dec 4, 2020

View reviewed changes

omerhabib26 approved these changes Dec 7, 2020

View reviewed changes

farhan-arshad-dev force-pushed the farhan_ar/LEARNER-8024 branch from 1ae460f to 978585c Compare December 7, 2020 17:40

Change Theme & Color throughout the App

3afc0d6

- LEARNER-8024 - Update color scheme throughout the app according to the new color paragon - Replace worldmap image on sign-in - Generate new Screenshots for screenshot test cases

farhan-arshad-dev force-pushed the farhan_ar/LEARNER-8024 branch from 978585c to 3afc0d6 Compare December 7, 2020 18:31

farhan-arshad-dev requested a review from omerhabib26 December 7, 2020 18:32

omerhabib26 approved these changes Dec 8, 2020

View reviewed changes

farhan-arshad-dev merged commit a376a46 into master Dec 8, 2020

farhan-arshad-dev deleted the farhan_ar/LEARNER-8024 branch December 8, 2020 06:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change Theme & Color throughout the App #1486

Change Theme & Color throughout the App #1486

farhan-arshad-dev commented Nov 26, 2020

farhan-arshad-dev commented Nov 26, 2020

omerhabib26 left a comment

omerhabib26 Nov 27, 2020

farhan-arshad-dev Dec 3, 2020

omerhabib26 Nov 27, 2020

farhan-arshad-dev Dec 3, 2020

farhan-arshad-dev commented Dec 3, 2020

omerhabib26 left a comment

codecov bot commented Dec 4, 2020 •

edited

omerhabib26 left a comment

omerhabib26 Dec 7, 2020

farhan-arshad-dev Dec 7, 2020

omerhabib26 Dec 7, 2020

farhan-arshad-dev Dec 7, 2020

omerhabib26 Dec 7, 2020

farhan-arshad-dev Dec 7, 2020

omerhabib26 left a comment

Change Theme & Color throughout the App #1486

Change Theme & Color throughout the App #1486

Conversation

farhan-arshad-dev commented Nov 26, 2020

Description

farhan-arshad-dev commented Nov 26, 2020

omerhabib26 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

farhan-arshad-dev commented Dec 3, 2020

omerhabib26 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 4, 2020 • edited

Codecov Report

omerhabib26 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

omerhabib26 left a comment

Choose a reason for hiding this comment

codecov bot commented Dec 4, 2020 •

edited