Upgrade pylint to 1.6.4 #51

Merged
merged 1 commit into from Jan 4, 2017

Projects

None yet

2 participants

@rlucioni
Member
rlucioni commented Dec 29, 2016 edited

I noticed we were several versions behind. For reference, here's Pylint's changelog.

@nedbat thoughts?

@rlucioni
Member

I'll run pylint 1.6.4 against another project to see what changes.

@nedbat
nedbat approved these changes Jan 3, 2017 View changes

I look forward to the results. This is good to go 👍

@rlucioni
Member
rlucioni commented Jan 3, 2017

@nedbat I ran this against course-discovery. The results look good. I saw a couple new suggestions to consider iterating across a dictionary instead of calling .keys() (consider-iterating-dictionary) and a few new instances of the no-member error, specifically related to format strings marked for i18n (e.g., _('{}').format('foo')).

Any questions or concerns before I merge this?

@rlucioni
Member
rlucioni commented Jan 4, 2017 edited

We spoke offline and wanted to know what this change will look like for edx-platform. I'm collecting data now.

pylint 1.4.5: 3518 violations
pylint 1.6.4: 6000 violations

@rlucioni rlucioni Upgrade pylint to 1.6.4
0d9b023
@rlucioni
Member
rlucioni commented Jan 4, 2017

For the record: I'm going to merge this and release an updated version to PyPI. edx-platform may not be able to use this version of the package immediately, but smaller projects will have an easier time making the jump.

@rlucioni rlucioni merged commit 687124b into master Jan 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rlucioni rlucioni deleted the renzo/upgrade-pylint branch Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment