Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move matplotlib to post requirements. #15101

Merged
merged 1 commit into from May 15, 2017

Conversation

@mtyaka
Copy link
Contributor

mtyaka commented May 12, 2017

Matplotlib depends on numpy, so we want to ensure the correct version of numpy is already installed when we attempt to install matplotlib.

A new version of numpy (1.13.0rc1) was released yesterday, which is breaking fresh installations on Ubuntu 16.04.

JIRA Ticket: OSPR-1765

Discussions: https://groups.google.com/forum/#!topic/openedx-ops/XB86A6MaCOs

Dependencies: None

Sandbox URLs:

Merge deadline: ASAP, this is breaking new installations.

Testing instructions:

  1. Try to deploy a new edx-platform instance based on master branch using default vagrant scripts from edx/configuration. Observe that the deployment fails at the "code sandbox | Install base sandbox requirements and create sandbox virtualenv" step.

  2. Deploy again, this time use the patch from this PR. Installation should now succeed.

Author notes and concerns:

Fresh installations of ficus.3 release are breaking too, so a new ficus.4 release should probably be released with this patch ASAP.

Reviewers

Matplotlib depends on numpy, so we want to ensure the correct version
of numpy is already installed when we attempt to install matplotlib.
@bradenmacdonald

This comment has been minimized.

Copy link
Member

bradenmacdonald commented May 12, 2017

@nedbat FYI

Copy link
Member

bradenmacdonald left a comment

👍 from me!

  • I tested this: Confirmed that this fixes the observed build error, via successful build of sandbox at https://pr15101.sandbox.opencraft.hosting/
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
@nedbat

This comment has been minimized.

Copy link
Member

nedbat commented May 15, 2017

👍

@nedbat nedbat merged commit 2dfb6ad into edx:master May 15, 2017
7 checks passed
7 checks passed
codecov/project 94.81% (target 85%)
Details
jenkins/a11y Build finished.
Details
jenkins/bokchoy Build finished.
Details
jenkins/js Build finished.
Details
jenkins/lettuce Build finished.
Details
jenkins/python Build finished.
Details
jenkins/quality Build finished.
Details
@edx-pipeline-bot

This comment has been minimized.

Copy link
Contributor

edx-pipeline-bot commented May 15, 2017

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, May 16, 2017.

eltoncarr added a commit to microsoft/edx-platform that referenced this pull request May 15, 2017
…l-fix

Move matplotlib to post requirements.
eltoncarr added a commit to microsoft/edx-platform that referenced this pull request May 15, 2017
Merge pull request edx#15101 from open-craft/mtyaka/matplotlib-install-fix
@edx-pipeline-bot

This comment has been minimized.

Copy link
Contributor

edx-pipeline-bot commented May 16, 2017

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.