Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frontend-base! #220

merged 19 commits into from Sep 16, 2019


Copy link

commented Sep 6, 2019

No description provided.

@davidjoy davidjoy force-pushed the buildercore branch from 97ff396 to 911bbae Sep 9, 2019

This comment has been minimized.

Copy link

commented Sep 9, 2019

Codecov Report

Merging #220 into master will increase coverage by 7.45%.
The diff coverage is 46.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #220      +/-   ##
+ Coverage    55.7%   63.15%   +7.45%     
  Files          52       46       -6     
  Lines         684      589      -95     
  Branches       87       74      -13     
- Hits          381      372       -9     
+ Misses        278      202      -76     
+ Partials       25       15      -10
Impacted Files Coverage Δ
...profile/components/forms/elements/FormControls.jsx 80% <ø> (ø) ⬆️
src/profile/reducers.js 0% <ø> (ø) ⬆️
src/profile/components/NotFoundPage.jsx 0% <ø> (ø)
src/utils.js 100% <ø> (ø)
...c/profile/components/forms/elements/Visibility.jsx 100% <ø> (ø) ⬆️
src/profile/components/forms/Name.jsx 60% <ø> (ø) ⬆️
src/profile/components/forms/ProfileAvatar.jsx 65.38% <ø> (ø) ⬆️
...c/profile/components/forms/elements/EditButton.jsx 100% <ø> (ø) ⬆️
src/profile/components/forms/Country.jsx 62.5% <ø> (ø) ⬆️
src/profile/components/PageLoading.jsx 80% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dd2a0c...070214c. Read the comment docs.

@davidjoy davidjoy force-pushed the buildercore branch from 52a35bd to dadd79b Sep 11, 2019
davidjoy and others added 11 commits Sep 4, 2019
- Adding APP_ERROR handler for top level errors.
- Splitting footer config out of main app config.
- Simplifying config variables and deriving some from others in the files that need them.
Getting rid of “common”
Updating a bunch of dependencies to their latest versions in the process.
@davidjoy davidjoy force-pushed the buildercore branch from af5420d to 7d21cef Sep 11, 2019
@davidjoy davidjoy marked this pull request as ready for review Sep 11, 2019
@davidjoy davidjoy changed the title [WIP] - frontend-core Use frontend-base! Sep 11, 2019
@davidjoy davidjoy requested review from abutterworth and edx/arch-fed Sep 12, 2019
.travis.yml Outdated Show resolved Hide resolved
src/profile/sagas.js Outdated Show resolved Hide resolved
Copy link

left a comment

Looks great

@davidjoy davidjoy merged commit 5ac0558 into master Sep 16, 2019
3 of 4 checks passed
3 of 4 checks passed
Datree Smart Policy Best Practices Verification
Datree insights datreeio insights events
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@davidjoy davidjoy deleted the buildercore branch Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.