Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perhaps a fix for stacked layouts #18

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

edzdez
Copy link
Owner

@edzdez edzdez commented May 16, 2024

This should hopefully fix the issue with stacked layouts.

This should hopefully fix the issue with stacked layouts.
@edzdez edzdez linked an issue May 16, 2024 that may be closed by this pull request
@edzdez edzdez changed the title Added some (hacky) code to keep track of container layouts. WIP: Added some (hacky) code to keep track of container layouts. May 16, 2024
@edzdez
Copy link
Owner Author

edzdez commented May 16, 2024

still some issues with calculating the position for labels.

Previously, we used what sway-msg gave; namely the height of the
decoration for each *individual* container.

Now, we set the decoration height to be the aggregate size of all the
decorations.
@edzdez edzdez changed the title WIP: Added some (hacky) code to keep track of container layouts. Added some (hacky) code to keep track of container layouts. May 17, 2024
@edzdez edzdez changed the title Added some (hacky) code to keep track of container layouts. Perhaps a fix for stacked layouts May 17, 2024
@edzdez edzdez merged commit 7f9ddd3 into main Jun 9, 2024
@edzdez edzdez deleted the 4-labels-are-drawn-wrong-in-the-stacked-layout branch June 9, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

labels are drawn wrong in the stacked layout
1 participant