New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3 #159

Open
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@pbauer
Contributor

pbauer commented Nov 10, 2018

Fixes #158

@pbauer

This comment has been minimized.

Contributor

pbauer commented Nov 10, 2018

@avoinea The tests are still partly failing but functionality is there.

@pbauer

This comment has been minimized.

Contributor

pbauer commented Nov 11, 2018

The change to use publishTraverse instead of allowed_interface in be2ac04 is a terrible idea and a very temporary workaround until zopefoundation/Zope#397 is fixed or a better workaround is found.

@pbauer

This comment has been minimized.

Contributor

pbauer commented Nov 11, 2018

Some of the remaining test-failures are not stable. They might come from FacetedVersion._digest that seems to return different hashes during different test-runs in py3. That seems to mess up the cache. It might also be due to the dict query not being the same.

Currently I have no more time to work on this.

It also requires a test-setup using tox with py2 and py3 and some more manual testing.

res.sort(key=operator.itemgetter(1), reverse=True)
maxitems = widget.maxitems
if maxitems:
res = res[:maxitems]
res.sort(key=operator.itemgetter(0), cmp=compare)
res.sort(key=lowercase)

This comment has been minimized.

@pbauer

pbauer Nov 11, 2018

Contributor

This is probably wrong since lowercase uses the second element for the comparison.

@avoinea

This comment has been minimized.

Member

avoinea commented Dec 12, 2018

It also requires a test-setup using tox with py2 and py3 and some more manual testing.

@pbauer Any good example?

@pbauer

This comment has been minimized.

Contributor

pbauer commented Dec 12, 2018

It also requires a test-setup using tox with py2 and py3 and some more manual testing.

@pbauer Any good example?

There is no canonical example yet. collective/collective.ifttt#82 might be the right direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment