Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3 #159

Merged
merged 24 commits into from Jul 1, 2019
Merged

Add support for Python 3 #159

merged 24 commits into from Jul 1, 2019

Conversation

@pbauer
Copy link
Contributor

@pbauer pbauer commented Nov 10, 2018

Fixes #158

@pbauer
Copy link
Contributor Author

@pbauer pbauer commented Nov 10, 2018

@avoinea The tests are still partly failing but functionality is there.

@pbauer
Copy link
Contributor Author

@pbauer pbauer commented Nov 11, 2018

The change to use publishTraverse instead of allowed_interface in be2ac04 is a terrible idea and a very temporary workaround until zopefoundation/Zope#397 is fixed or a better workaround is found.

@pbauer
Copy link
Contributor Author

@pbauer pbauer commented Nov 11, 2018

Some of the remaining test-failures are not stable. They might come from FacetedVersion._digest that seems to return different hashes during different test-runs in py3. That seems to mess up the cache. It might also be due to the dict query not being the same.

Currently I have no more time to work on this.

It also requires a test-setup using tox with py2 and py3 and some more manual testing.

res.sort(key=operator.itemgetter(1), reverse=True)

maxitems = widget.maxitems
if maxitems:
res = res[:maxitems]
res.sort(key=operator.itemgetter(0), cmp=compare)
res.sort(key=lowercase)

This comment has been minimized.

@pbauer

pbauer Nov 11, 2018
Author Contributor

This is probably wrong since lowercase uses the second element for the comparison.

@avoinea
Copy link
Member

@avoinea avoinea commented Dec 12, 2018

It also requires a test-setup using tox with py2 and py3 and some more manual testing.

@pbauer Any good example?

@pbauer
Copy link
Contributor Author

@pbauer pbauer commented Dec 12, 2018

It also requires a test-setup using tox with py2 and py3 and some more manual testing.

@pbauer Any good example?

There is no canonical example yet. collective/collective.ifttt#82 might be the right direction.

…e 4 and Python 3, because its publishTraverse endpoints returned None for ZPublisher
@pbauer
Copy link
Contributor Author

@pbauer pbauer commented Apr 14, 2019

@avoinea bobtemplates.plone now creates a test-setup that allows to test various plone and python-versions. One example with a complete setup is https://github.com/collective/collective.edtf_behavior

avoinea added 3 commits Apr 19, 2019
@avoinea avoinea changed the base branch from master to develop Apr 19, 2019
avoinea and others added 2 commits Apr 19, 2019
@jensens
Copy link
Contributor

@jensens jensens commented Apr 24, 2019

This branch is also needed for Plone 5.2 under Python 2.7. It addresses changes from Zope 2 -> 4 as well, needed to this addon!

@deepcode-ci-bot
Copy link

@deepcode-ci-bot deepcode-ci-bot bot commented May 2, 2019

DeepCode analyzed this pull request.
There are 9 new info reports. 4 info reports were fixed.

Click to see more details.

@jensens jensens force-pushed the collective:python3 branch 2 times, most recently from 269e6aa to d679fa0 Jun 25, 2019
@jensens jensens force-pushed the collective:python3 branch from d679fa0 to 4d6d9b2 Jun 25, 2019
@jensens jensens force-pushed the collective:python3 branch from 4d6d9b2 to aa51d9a Jun 25, 2019
@jensens jensens force-pushed the collective:python3 branch from 4ef6fb9 to 4ecaa09 Jun 25, 2019
avoinea and others added 2 commits Jun 26, 2019
@jensens jensens force-pushed the collective:python3 branch from 8d66ac2 to 2708116 Jun 26, 2019
pbauer and others added 3 commits Jun 24, 2019
…rator

Only use operator in query if index supports it
@jensens
Copy link
Contributor

@jensens jensens commented Jul 1, 2019

Btw,. what is missing to merge this?

@avoinea
Copy link
Member

@avoinea avoinea commented Jul 1, 2019

Thank you all for this PR. I will take a look and merge if everything OK.

@avoinea
avoinea approved these changes Jul 1, 2019
@avoinea avoinea merged commit 8296692 into eea:develop Jul 1, 2019
1 check passed
1 check passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
@avoinea avoinea deleted the collective:python3 branch Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants