New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xsd boolean fix #179

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@rssh
Contributor

rssh commented Dec 14, 2012

added support for lexical boolean representation during parsing (i.e. "0" and "1" in addtion to "true" and "false", as specified in http://www.w3.org/TR/xmlschema-2/#boolean) and added appropriative test in generic tests.

Also fix generic text evaluation for my set of libraries [openjdk-1.7 / scala-2.9.2]

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Dec 16, 2012

Owner

Thanks for the contribution. I am using Scala 2.10.0-RC5 for the integration tests. Could you roll back the 2.9.2 specific changes you made in GeneralUsage.scala, and squash all commits into one?

Owner

eed3si9n commented Dec 16, 2012

Thanks for the contribution. I am using Scala 2.10.0-RC5 for the integration tests. Could you roll back the 2.9.2 specific changes you made in GeneralUsage.scala, and squash all commits into one?

@rssh

This comment has been minimized.

Show comment
Hide comment
@rssh

rssh Dec 17, 2012

Contributor

btw, I rerun tests with scala-2.10.0-RC5 and changes still required to pass integration tests on my machine. [ openjkdk-7 on Frdora Linux / 64 ] Look;s like this behavior depends not from scala version, but from default xml libraries in java installation. Note, that my changes in tests must not broke anything -- they just add 'positive cases', which differs from original positive case xml only in order of attributes or notation for empty element (which both still valid). So, changes in tests are not 2.9.2 specifics -- will change comments.

[will rebase all in one commit .. hope today's evening]

Contributor

rssh commented Dec 17, 2012

btw, I rerun tests with scala-2.10.0-RC5 and changes still required to pass integration tests on my machine. [ openjkdk-7 on Frdora Linux / 64 ] Look;s like this behavior depends not from scala version, but from default xml libraries in java installation. Note, that my changes in tests must not broke anything -- they just add 'positive cases', which differs from original positive case xml only in order of attributes or notation for empty element (which both still valid). So, changes in tests are not 2.9.2 specifics -- will change comments.

[will rebase all in one commit .. hope today's evening]

@rssh

This comment has been minimized.

Show comment
Hide comment
@rssh

rssh Dec 17, 2012

Contributor

rebased version will be in next pull-request.

Contributor

rssh commented Dec 17, 2012

rebased version will be in next pull-request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment