New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trimming of URI tag contents. #185

Merged
merged 2 commits into from Jan 13, 2013

Conversation

Projects
None yet
2 participants
@colinrgodsey
Contributor

colinrgodsey commented Jan 9, 2013

Made change in toURI to trim the string before converting it to a URI.

This is helpful with human formated XML:

<uriTag>
      http://www.this.url.wont.parse/because.of/whitespace.html
</uriTag>

Colin Godsey and others added some commits Jan 7, 2013

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jan 9, 2013

Owner

Hi. Sorry I haven't made comments on this issue. This is a valid enhancement, but I was thinking whether I should include this into current 1.0 or the next 2.0, which might not come out for a while.

Owner

eed3si9n commented Jan 9, 2013

Hi. Sorry I haven't made comments on this issue. This is a valid enhancement, but I was thinking whether I should include this into current 1.0 or the next 2.0, which might not come out for a while.

@@ -405,7 +405,7 @@ object DataRecord extends XMLStandardTypes {
case _ => DataRecord(value)
}
def apply[A:CanWriteXML](node: Node, parent: Node, value: A): DataRecord[A] = node match {
def apply[A:CanWriteXML](node: Node, parent: Node, value: A): DataRecord[A] = (node: Any) match {

This comment has been minimized.

@eed3si9n

eed3si9n Jan 9, 2013

Owner

Why is node expanded to Any?

@eed3si9n

eed3si9n Jan 9, 2013

Owner

Why is node expanded to Any?

This comment has been minimized.

@colinrgodsey

colinrgodsey Jan 9, 2013

Contributor

dang, forgot to stash this before committing.

In that particular method, scala 2.10.0 throws a warning (and valid point) that UnprefixedAttribute and PrefixedAttribute can never be of type Node, this may have been something changed in 2.10.0 scala. I made the above change to suppress the warning, but forgot to undo/stash.

@colinrgodsey

colinrgodsey Jan 9, 2013

Contributor

dang, forgot to stash this before committing.

In that particular method, scala 2.10.0 throws a warning (and valid point) that UnprefixedAttribute and PrefixedAttribute can never be of type Node, this may have been something changed in 2.10.0 scala. I made the above change to suppress the warning, but forgot to undo/stash.

@colinrgodsey

This comment has been minimized.

Show comment
Hide comment
@colinrgodsey

colinrgodsey Jan 9, 2013

Contributor

no problem! it might have some use to people in the 1.0 version. I currently have to patch the generated files during compile to get it to work for our project's needs.

Contributor

colinrgodsey commented Jan 9, 2013

no problem! it might have some use to people in the 1.0 version. I currently have to patch the generated files during compile to get it to work for our project's needs.

eed3si9n added a commit that referenced this pull request Jan 13, 2013

Merge pull request #185 from colinrgodsey/master
Trimming of URI tag contents.

@eed3si9n eed3si9n merged commit fb06cf2 into eed3si9n:master Jan 13, 2013

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jan 13, 2013

Owner

Merged.

Owner

eed3si9n commented Jan 13, 2013

Merged.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jan 24, 2013

Owner

scalaxb 1.0.1 is out with this change.

Owner

eed3si9n commented Jan 24, 2013

scalaxb 1.0.1 is out with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment