New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Lenses for all generated classes in the XSD. #292

Merged
merged 8 commits into from Nov 23, 2014

Conversation

Projects
None yet
2 participants
@lbruand
Contributor

lbruand commented Nov 12, 2014

We would like scalaxb to generate Lenses for all objects in the XSD.
This way, manipulating the XML graph is a lot more beautiful. (and you can use the completion to access the lens.)
We use scalaz Lenses.
This feature is optional.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Nov 12, 2014

Owner

Thanks for the contribution. This looks cool.
Do you mind adding usage code into the integration test? You can add dependency to Scalaz in integrationTest here:

def integrationDependencies(sv: String) = Seq(
dispatch % "test",
scalaCompiler(sv),
specs2(sv) % "test",
cxfFrontendJaxws % "test",
cxfTransportsHttp % "test",
cxfTrapsportsHttpJetty % "test"
)

Owner

eed3si9n commented Nov 12, 2014

Thanks for the contribution. This looks cool.
Do you mind adding usage code into the integration test? You can add dependency to Scalaz in integrationTest here:

def integrationDependencies(sv: String) = Seq(
dispatch % "test",
scalaCompiler(sv),
specs2(sv) % "test",
cxfFrontendJaxws % "test",
cxfTransportsHttp % "test",
cxfTrapsportsHttpJetty % "test"
)

working on test - still having a problem with repeated parameter in c…
…ase class because they don't have a copy method
@lbruand

This comment has been minimized.

Show comment
Hide comment
@lbruand

lbruand Nov 16, 2014

Contributor

I am struggling a bit with the test because apparently case classes with repeated parameters don't have copy methods. Which makes it a lot harder to write Lenses.

Contributor

lbruand commented Nov 16, 2014

I am struggling a bit with the test because apparently case classes with repeated parameters don't have copy methods. Which makes it a lot harder to write Lenses.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Nov 16, 2014

Owner

The vararg thing is a bit of a cheesy feature, so I don't mind that being optional feature.

Owner

eed3si9n commented Nov 16, 2014

The vararg thing is a bit of a cheesy feature, so I don't mind that being optional feature.

@lbruand

This comment has been minimized.

Show comment
Hide comment
@lbruand

lbruand Nov 16, 2014

Contributor

related to : use Seq instead of varargs #201

Contributor

lbruand commented Nov 16, 2014

related to : use Seq instead of varargs #201

@lbruand

This comment has been minimized.

Show comment
Hide comment
@lbruand

lbruand Nov 17, 2014

Contributor

Hello,

I have added parametrization but one the test (Wsdl11Soap11Test) is failing but was failing before I started coding... Thanks!
Lucas

Contributor

lbruand commented Nov 17, 2014

Hello,

I have added parametrization but one the test (Wsdl11Soap11Test) is failing but was failing before I started coding... Thanks!
Lucas

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Nov 17, 2014

Instead of including a condition there, config.useVarArg or something should be added be part of val hasSequenceParam at line 268.

Instead of including a condition there, config.useVarArg or something should be added be part of val hasSequenceParam at line 268.

@lbruand

This comment has been minimized.

Show comment
Hide comment
@lbruand

lbruand Nov 21, 2014

Contributor

Hi !
Sorry for taking so long to carry on. I hope this is what you were expecting. I hope this feature is interesting enough to get pulled.
Thanks anyway,
Lucas

Contributor

lbruand commented Nov 21, 2014

Hi !
Sorry for taking so long to carry on. I hope this is what you were expecting. I hope this feature is interesting enough to get pulled.
Thanks anyway,
Lucas

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Nov 21, 2014

Owner

LGTM. Do you want to add anything else before I merge?

Owner

eed3si9n commented Nov 21, 2014

LGTM. Do you want to add anything else before I merge?

@lbruand

This comment has been minimized.

Show comment
Hide comment
@lbruand

lbruand Nov 22, 2014

Contributor

Nope, I cannot think of anything else...

Thanks
Le 21 nov. 2014 23:30, "eugene yokota" notifications@github.com a écrit :

LGTM. Do you want to add anything else before I merge?


Reply to this email directly or view it on GitHub
#292 (comment).

Contributor

lbruand commented Nov 22, 2014

Nope, I cannot think of anything else...

Thanks
Le 21 nov. 2014 23:30, "eugene yokota" notifications@github.com a écrit :

LGTM. Do you want to add anything else before I merge?


Reply to this email directly or view it on GitHub
#292 (comment).

eed3si9n added a commit that referenced this pull request Nov 23, 2014

Merge pull request #292 from lbruand/master
Generate Lenses for all generated classes in the XSD.

@eed3si9n eed3si9n merged commit 01c855d into eed3si9n:master Nov 23, 2014

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Nov 23, 2014

Owner

Merged. Thanks for your contribution.

Owner

eed3si9n commented Nov 23, 2014

Merged. Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment