New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useVarArgs option in mvn-scalaxb #309

Merged
merged 1 commit into from Feb 20, 2015

Conversation

Projects
None yet
3 participants
@Erwan56

Erwan56 commented Feb 11, 2015

This pull request is linked to the following one #292. It allows maven users to configure useVarArgs option.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n
Owner

eed3si9n commented Feb 11, 2015

/review @martiell

@lbruand

This comment has been minimized.

Show comment
Hide comment
@lbruand

lbruand Feb 13, 2015

Contributor

👍
Hello,

This would be super useful for us.

Thanks,
Lucas

Contributor

lbruand commented Feb 13, 2015

👍
Hello,

This would be super useful for us.

Thanks,
Lucas

eed3si9n added a commit that referenced this pull request Feb 20, 2015

Merge pull request #309 from Erwan56/master
Add useVarArgs option in mvn-scalaxb

@eed3si9n eed3si9n merged commit d502f33 into eed3si9n:master Feb 20, 2015

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Feb 20, 2015

Owner

I just merged it but use-varargs doesn't make sense if that's the default value. We need no-varargs as Unit flag. I can fix this myself.

Owner

eed3si9n commented Feb 20, 2015

I just merged it but use-varargs doesn't make sense if that's the default value. We need no-varargs as Unit flag. I can fix this myself.

@eed3si9n eed3si9n referenced this pull request Feb 20, 2015

Open

no-varargs is needed #311

@Erwan56

This comment has been minimized.

Show comment
Hide comment
@Erwan56

Erwan56 Feb 21, 2015

Ok. That means that you reverse the option
use-varargs = false < = > no-varargs = true

Sounds good.

Erwan56 commented Feb 21, 2015

Ok. That means that you reverse the option
use-varargs = false < = > no-varargs = true

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment