New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore unknown elements in response #310

Merged
merged 7 commits into from Apr 21, 2015

Conversation

Projects
None yet
2 participants
@jet-black

jet-black commented Feb 16, 2015

Our team wants scalaxb to be able to ignore unknown xml elements inside response, as well as ignoring order in which they are arrived. It is against XSD specification, but it is very useful when another server changes it's schema without notifying clients. Please, review this request.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Feb 16, 2015

Owner

I have a few minor comments, but overall this looks like a really nice addition to scalaxb.
Thanks a lot!

Owner

eed3si9n commented Feb 16, 2015

I have a few minor comments, but overall this looks like a really nice addition to scalaxb.
Thanks a lot!

@jet-black

This comment has been minimized.

Show comment
Hide comment
@jet-black

jet-black Mar 27, 2015

Ok, I've resolved conflicts. We've made some load testing on that feature. Also we are already using this feature in production under highload, so the changes are working fine without any errors.

jet-black commented Mar 27, 2015

Ok, I've resolved conflicts. We've made some load testing on that feature. Also we are already using this feature in production under highload, so the changes are working fine without any errors.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Mar 27, 2015

Owner

I can no longer see whatever I commented, but thanks for the update.
I am guessing one of them is that it fixes #291/#298, which should be noted in the release note.

Owner

eed3si9n commented Mar 27, 2015

I can no longer see whatever I commented, but thanks for the update.
I am guessing one of them is that it fixes #291/#298, which should be noted in the release note.

@jet-black

This comment has been minimized.

Show comment
Hide comment
@jet-black

jet-black Mar 27, 2015

I've made updates for notes, please, review.

jet-black commented Mar 27, 2015

I've made updates for notes, please, review.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Mar 27, 2015

This change should actually go into a new file called notes/1.4.0.markdown along with the description of the main change added by this PR.

eed3si9n commented on beb9bc3 Mar 27, 2015

This change should actually go into a new file called notes/1.4.0.markdown along with the description of the main change added by this PR.

This comment has been minimized.

Show comment
Hide comment
@jet-black

jet-black Mar 30, 2015

Owner

New file (1.4.0 markdown) created. Please, review.

Owner

jet-black replied Mar 30, 2015

New file (1.4.0 markdown) created. Please, review.

eed3si9n added a commit that referenced this pull request Apr 21, 2015

Merge pull request #310 from jet-black/master
Ability to ignore unknown elements in response

@eed3si9n eed3si9n merged commit 539ea27 into eed3si9n:master Apr 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment