Ability to ignore unknown elements in response #310

Merged
merged 7 commits into from Apr 21, 2015

Projects

None yet

2 participants

@jet-black

Our team wants scalaxb to be able to ignore unknown xml elements inside response, as well as ignoring order in which they are arrived. It is against XSD specification, but it is very useful when another server changes it's schema without notifying clients. Please, review this request.

@eed3si9n
Owner

I have a few minor comments, but overall this looks like a really nice addition to scalaxb.
Thanks a lot!

@jet-black

Ok, I've resolved conflicts. We've made some load testing on that feature. Also we are already using this feature in production under highload, so the changes are working fine without any errors.

@eed3si9n
Owner

I can no longer see whatever I commented, but thanks for the update.
I am guessing one of them is that it fixes #291/#298, which should be noted in the release note.

d.a.ovechkin Update notes beb9bc3
@jet-black

I've made updates for notes, please, review.

@eed3si9n
Owner

This change should actually go into a new file called notes/1.4.0.markdown along with the description of the main change added by this PR.

New file (1.4.0 markdown) created. Please, review.

@eed3si9n eed3si9n merged commit 539ea27 into eed3si9n:master Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment