Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore unknown elements in response #310

Merged
merged 7 commits into from Apr 21, 2015
Merged

Ability to ignore unknown elements in response #310

merged 7 commits into from Apr 21, 2015

Conversation

ovechkin-dm
Copy link

Our team wants scalaxb to be able to ignore unknown xml elements inside response, as well as ignoring order in which they are arrived. It is against XSD specification, but it is very useful when another server changes it's schema without notifying clients. Please, review this request.

@eed3si9n
Copy link
Owner

I have a few minor comments, but overall this looks like a really nice addition to scalaxb.
Thanks a lot!

@ovechkin-dm
Copy link
Author

Ok, I've resolved conflicts. We've made some load testing on that feature. Also we are already using this feature in production under highload, so the changes are working fine without any errors.

@eed3si9n
Copy link
Owner

I can no longer see whatever I commented, but thanks for the update.
I am guessing one of them is that it fixes #291/#298, which should be noted in the release note.

@ovechkin-dm
Copy link
Author

I've made updates for notes, please, review.

eed3si9n added a commit that referenced this pull request Apr 21, 2015
Ability to ignore unknown elements in response
@eed3si9n eed3si9n merged commit 539ea27 into eed3si9n:master Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants