Skip to content

Bump dispatch to version 0.11.3#352

Merged
eed3si9n merged 2 commits into
eed3si9n:masterfrom
Banno:dispatch-0.11.3
Sep 2, 2015
Merged

Bump dispatch to version 0.11.3#352
eed3si9n merged 2 commits into
eed3si9n:masterfrom
Banno:dispatch-0.11.3

Conversation

@DustinChaloupka

Copy link
Copy Markdown
Contributor

This bumps the dispatch version to 0.11.3. I was unsure if there were specific tests to be added for each specific version of dispatch instead of just the tests handling whatever the default dispatch version were, but they all passed.

@eed3si9n

eed3si9n commented Sep 2, 2015

Copy link
Copy Markdown
Owner

@eed3si9n

eed3si9n commented Sep 2, 2015

Copy link
Copy Markdown
Owner

Also what's the difference between httpclients_dispatch0111.scala.template and httpclients_dispatch0113.scala.template?

@DustinChaloupka

Copy link
Copy Markdown
Contributor Author

The only differences are the changes in the method names.

setConnectionTimeoutInMs -> setConnectTimeout

Also did not know that the 0.11.3 version not "officially" released, but was working with something that is using it so figured I would open this PR. Feel free to close it if will not be used. :)

Comment thread project/dependencies.scala Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pull request overall is useful if source change was required due to dispatch/reboot#116, but could we keep the defaultDispatchVersion to 0.11.2?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

eed3si9n added a commit that referenced this pull request Sep 2, 2015
Bump dispatch to version 0.11.3
@eed3si9n eed3si9n merged commit 17be995 into eed3si9n:master Sep 2, 2015
@eed3si9n

eed3si9n commented Sep 2, 2015

Copy link
Copy Markdown
Owner

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants