New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dispatch to version 0.11.3 #352
Conversation
Currently the announced "latest" is 0.11.2 on http://dispatch.databinder.net/Dispatch.html. See also https://groups.google.com/d/msg/dispatch-scala/iy12POc81LM/udzLH14ajcMJ |
Also what's the difference between httpclients_dispatch0111.scala.template and httpclients_dispatch0113.scala.template? |
The only differences are the changes in the method names.
Also did not know that the |
@@ -7,7 +7,7 @@ object Dependencies { | |||
|
|||
val scopt = "com.github.scopt" %% "scopt" % "3.2.0" | |||
val log4j = "log4j" % "log4j" % "1.2.17" | |||
val defaultDispatchVersion = "0.11.2" | |||
val defaultDispatchVersion = "0.11.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this pull request overall is useful if source change was required due to dispatch/reboot#116, but could we keep the defaultDispatchVersion to 0.11.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
Bump dispatch to version 0.11.3
Thanks for the contribution. |
This bumps the dispatch version to
0.11.3
. I was unsure if there were specific tests to be added for each specific version of dispatch instead of just the tests handling whatever the default dispatch version were, but they all passed.