Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dispatch to version 0.11.3 #352

Merged
merged 2 commits into from Sep 2, 2015
Merged

Conversation

DustinChaloupka
Copy link
Contributor

This bumps the dispatch version to 0.11.3. I was unsure if there were specific tests to be added for each specific version of dispatch instead of just the tests handling whatever the default dispatch version were, but they all passed.

@eed3si9n
Copy link
Owner

eed3si9n commented Sep 2, 2015

@eed3si9n
Copy link
Owner

eed3si9n commented Sep 2, 2015

Also what's the difference between httpclients_dispatch0111.scala.template and httpclients_dispatch0113.scala.template?

@DustinChaloupka
Copy link
Contributor Author

The only differences are the changes in the method names.

setConnectionTimeoutInMs -> setConnectTimeout

Also did not know that the 0.11.3 version not "officially" released, but was working with something that is using it so figured I would open this PR. Feel free to close it if will not be used. :)

@@ -7,7 +7,7 @@ object Dependencies {

val scopt = "com.github.scopt" %% "scopt" % "3.2.0"
val log4j = "log4j" % "log4j" % "1.2.17"
val defaultDispatchVersion = "0.11.2"
val defaultDispatchVersion = "0.11.3"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this pull request overall is useful if source change was required due to dispatch/reboot#116, but could we keep the defaultDispatchVersion to 0.11.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

eed3si9n added a commit that referenced this pull request Sep 2, 2015
Bump dispatch to version 0.11.3
@eed3si9n eed3si9n merged commit 17be995 into eed3si9n:master Sep 2, 2015
@eed3si9n
Copy link
Owner

eed3si9n commented Sep 2, 2015

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants