New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dispatch to version 0.11.3 #352

Merged
merged 2 commits into from Sep 2, 2015

Conversation

Projects
None yet
2 participants
@DustinChaloupka
Contributor

DustinChaloupka commented Sep 2, 2015

This bumps the dispatch version to 0.11.3. I was unsure if there were specific tests to be added for each specific version of dispatch instead of just the tests handling whatever the default dispatch version were, but they all passed.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
Owner

eed3si9n commented Sep 2, 2015

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Sep 2, 2015

Owner

Also what's the difference between httpclients_dispatch0111.scala.template and httpclients_dispatch0113.scala.template?

Owner

eed3si9n commented Sep 2, 2015

Also what's the difference between httpclients_dispatch0111.scala.template and httpclients_dispatch0113.scala.template?

@DustinChaloupka

This comment has been minimized.

Show comment
Hide comment
@DustinChaloupka

DustinChaloupka Sep 2, 2015

Contributor

The only differences are the changes in the method names.

setConnectionTimeoutInMs -> setConnectTimeout

Also did not know that the 0.11.3 version not "officially" released, but was working with something that is using it so figured I would open this PR. Feel free to close it if will not be used. :)

Contributor

DustinChaloupka commented Sep 2, 2015

The only differences are the changes in the method names.

setConnectionTimeoutInMs -> setConnectTimeout

Also did not know that the 0.11.3 version not "officially" released, but was working with something that is using it so figured I would open this PR. Feel free to close it if will not be used. :)

eed3si9n added a commit that referenced this pull request Sep 2, 2015

Merge pull request #352 from Banno/dispatch-0.11.3
Bump dispatch to version 0.11.3

@eed3si9n eed3si9n merged commit 17be995 into eed3si9n:master Sep 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Sep 2, 2015

Owner

Thanks for the contribution.

Owner

eed3si9n commented Sep 2, 2015

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment