Bump dispatch to version 0.11.3 #352

Merged
merged 2 commits into from Sep 2, 2015

Projects

None yet

2 participants

@DustinChaloupka
Contributor

This bumps the dispatch version to 0.11.3. I was unsure if there were specific tests to be added for each specific version of dispatch instead of just the tests handling whatever the default dispatch version were, but they all passed.

@eed3si9n
Owner
eed3si9n commented Sep 2, 2015

Also what's the difference between httpclients_dispatch0111.scala.template and httpclients_dispatch0113.scala.template?

@DustinChaloupka
Contributor

The only differences are the changes in the method names.

setConnectionTimeoutInMs -> setConnectTimeout

Also did not know that the 0.11.3 version not "officially" released, but was working with something that is using it so figured I would open this PR. Feel free to close it if will not be used. :)

@eed3si9n eed3si9n and 1 other commented on an outdated diff Sep 2, 2015
project/dependencies.scala
@@ -7,7 +7,7 @@ object Dependencies {
val scopt = "com.github.scopt" %% "scopt" % "3.2.0"
val log4j = "log4j" % "log4j" % "1.2.17"
- val defaultDispatchVersion = "0.11.2"
+ val defaultDispatchVersion = "0.11.3"
@eed3si9n
eed3si9n Sep 2, 2015 Owner

I think this pull request overall is useful if source change was required due to dispatch/reboot#116, but could we keep the defaultDispatchVersion to 0.11.2?

@DustinChaloupka
DustinChaloupka Sep 2, 2015 Contributor

Changed.

@eed3si9n eed3si9n merged commit 17be995 into eed3si9n:master Sep 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eed3si9n
Owner
eed3si9n commented Sep 2, 2015

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment