Bug fix for SOAP operations which use multiple implicit headers #380

Merged
merged 1 commit into from Jul 19, 2016

Projects

None yet

2 participants

@joshlreese
Contributor
joshlreese commented Jul 19, 2016 edited

Ref #366

A failure to compile occurs when a WSDL with an operation which declares multiple implicit input headers use different parts defined in the same message.

Each time a message is used to define a header, all parts of that message are added as parameters to the generated method, resulting in duplicates and a failure to compile.

Steps:

  1. Define operation which declares multiple implicit input headers using different parts of the same message. (See implicit_header_multiple_part_header.wsdl)
  2. Compile

Problem:
Duplicate parameters generated:

def createUser(username: String, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart): Either[scalaxb.Fault[Any], implicitheadermultipart.QuoteResponse]

Expectation:
Unique parameters generated:
def createUser(username: String, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart): Either[scalaxb.Fault[Any], implicitheadermultipart.QuoteResponse]

Note:
The implicit header functionality was added in #366

Changes made:
The code generator for including implicit headers will now only include the part of the message explicitly defined in the SOAP header.

@eed3si9n
Owner

LGTM

@eed3si9n eed3si9n merged commit 40ad5ce into eed3si9n:master Jul 19, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment