Skip to content

Bug fix for SOAP operations which use multiple implicit headers#380

Merged
eed3si9n merged 1 commit into
eed3si9n:masterfrom
joshlreese:implicit_header_multi_part
Jul 19, 2016
Merged

Bug fix for SOAP operations which use multiple implicit headers#380
eed3si9n merged 1 commit into
eed3si9n:masterfrom
joshlreese:implicit_header_multi_part

Conversation

@joshlreese

@joshlreese joshlreese commented Jul 19, 2016

Copy link
Copy Markdown
Contributor

Ref #366

A failure to compile occurs when a WSDL with an operation which declares multiple implicit input headers use different parts defined in the same message.

Each time a message is used to define a header, all parts of that message are added as parameters to the generated method, resulting in duplicates and a failure to compile.

Steps:

  1. Define operation which declares multiple implicit input headers using different parts of the same message. (See implicit_header_multiple_part_header.wsdl)
  2. Compile

Problem:
Duplicate parameters generated:

def createUser(username: String, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart): Either[scalaxb.Fault[Any], implicitheadermultipart.QuoteResponse]

Expectation:
Unique parameters generated:
def createUser(username: String, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart): Either[scalaxb.Fault[Any], implicitheadermultipart.QuoteResponse]

Note:
The implicit header functionality was added in #366

Changes made:
The code generator for including implicit headers will now only include the part of the message explicitly defined in the SOAP header.

@eed3si9n

Copy link
Copy Markdown
Owner

LGTM

@eed3si9n
eed3si9n merged commit 40ad5ce into eed3si9n:master Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants