Bug fix for SOAP operations which use multiple implicit headers#380
Merged
Conversation
…ined in the same message.
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #366
A failure to compile occurs when a WSDL with an operation which declares multiple implicit input headers use different parts defined in the same message.
Each time a message is used to define a header, all parts of that message are added as parameters to the generated method, resulting in duplicates and a failure to compile.
Steps:
Problem:
Duplicate parameters generated:
def createUser(username: String, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart): Either[scalaxb.Fault[Any], implicitheadermultipart.QuoteResponse]Expectation:
Unique parameters generated:
def createUser(username: String, session: implicitheadermultipart.Session, anotherPart: implicitheadermultipart.AnotherPart): Either[scalaxb.Fault[Any], implicitheadermultipart.QuoteResponse]Note:
The implicit header functionality was added in #366
Changes made:
The code generator for including implicit headers will now only include the
partof the message explicitly defined in the SOAP header.