Name clashes in protocol#385
Merged
eed3si9n merged 2 commits intoAug 10, 2016
Merged
Conversation
Owner
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy-pasting the info on the bug from my previous PR:
Name clashes in
protocol.xmlConsider OpenOffice schemata, files
dml-main.xsdandsml.xsd. Both define<xsd:complexType name="CT_Table">. When generating them in different packages,protocol.scalagenerates classes with identical names for both of these types.This is due to the following code in the
compiler/xsd/Lookup.scala:So if the package names have the identical last part, there will be a clash.
Since
protocol.scalais not supposed to be used directly by the end user and is needed only for the implicits, we decided to use the entire package name to construct these class names. This way, they are much longer, but unambiguous.