Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy-pasting the info on the bug from my previous PR:
Name clashes in
protocol.xml
Consider OpenOffice schemata, files
dml-main.xsd
andsml.xsd
. Both define<xsd:complexType name="CT_Table">
. When generating them in different packages,protocol.scala
generates classes with identical names for both of these types.This is due to the following code in the
compiler/xsd/Lookup.scala
:So if the package names have the identical last part, there will be a clash.
Since
protocol.scala
is not supposed to be used directly by the end user and is needed only for the implicits, we decided to use the entire package name to construct these class names. This way, they are much longer, but unambiguous.