New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum name conflicts #386
Enum name conflicts #386
Conversation
LGTM pending Travis |
I've also included the commit for tests to be executed sequentially. I tried to run the Travis tests for this PR two times. In both cases, First time output:
Second time output:
Note the different errors and different number of failed examples. Note also a particular fragment from the first run:
Clearly the line couldn't be written properly. Highly suggests concurrency issues. From my previous PR: Tests are executed sequentiallyIn process of their work, test examples generate files to Since We have disabled the parallel execution of the test examples for that reason, we did not experience any disastrous performance drops because of it. |
Seems like the tests are passing now with the last change. |
The issue with enum names conflicting with Scala base names turned out to only affect the "Nil" word. So I just added it to the list of Scala names, and also a test to verify the behaviour, since I haven't found one.