New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken compile with lowercase header parts #400

Merged
merged 1 commit into from Sep 30, 2016

Conversation

Projects
None yet
3 participants
@jankeesvanandel
Contributor

jankeesvanandel commented Sep 29, 2016

Hey,

We use scalaxb and after upgrading to v1.4.1 things broke in the compile phase. This was the error:

[info] Compiling 11 Scala sources to /***/target/scala-2.11/classes...
[error] /***/target/scala-2.11/src_managed/main/sbt-scalaxb/***/wsdl/MyService.scala:9: getGroupProfileRequest is already defined as value getGroupProfileRequest

And this was the generated source file, causing the error:

trait MyService {
  def getGroupProfile(getGroupProfileRequest: ***.wsdl.GetGroupProfileRequest, authenticationHeader: ***.wsdl.AuthenticationHeader, getGroupProfileRequest: ***.wsdl.GetGroupProfileRequest, authenticationHeader: ***.wsdl.AuthenticationHeader): Future[***.wsdl.GetGroupProfileResponse]
}

As you can see, the header and body part arguments were added twice.

We found out that this was introduced in commit 8b2b20d, the reason being a lowerCase operation that was applied only on one place, causing Map lookup misses.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Sep 30, 2016

Owner

Thanks for the contribution!

Owner

eed3si9n commented Sep 30, 2016

Thanks for the contribution!

@eed3si9n eed3si9n merged commit 5e8c00d into eed3si9n:master Sep 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment