Skip to content

Fixed broken compile with lowercase header parts#400

Merged
eed3si9n merged 1 commit intoeed3si9n:masterfrom
jankeesvanandel:master
Sep 30, 2016
Merged

Fixed broken compile with lowercase header parts#400
eed3si9n merged 1 commit intoeed3si9n:masterfrom
jankeesvanandel:master

Conversation

@jankeesvanandel
Copy link
Copy Markdown
Contributor

Hey,

We use scalaxb and after upgrading to v1.4.1 things broke in the compile phase. This was the error:

[info] Compiling 11 Scala sources to /***/target/scala-2.11/classes...
[error] /***/target/scala-2.11/src_managed/main/sbt-scalaxb/***/wsdl/MyService.scala:9: getGroupProfileRequest is already defined as value getGroupProfileRequest

And this was the generated source file, causing the error:

trait MyService {
  def getGroupProfile(getGroupProfileRequest: ***.wsdl.GetGroupProfileRequest, authenticationHeader: ***.wsdl.AuthenticationHeader, getGroupProfileRequest: ***.wsdl.GetGroupProfileRequest, authenticationHeader: ***.wsdl.AuthenticationHeader): Future[***.wsdl.GetGroupProfileResponse]
}

As you can see, the header and body part arguments were added twice.

We found out that this was introduced in commit 8b2b20d, the reason being a lowerCase operation that was applied only on one place, causing Map lookup misses.

@eed3si9n
Copy link
Copy Markdown
Owner

Thanks for the contribution!

@eed3si9n eed3si9n merged commit 5e8c00d into eed3si9n:master Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants