New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gigahorse http library. #413

Merged
merged 4 commits into from Jan 25, 2017

Conversation

Projects
None yet
3 participants
@alexdupre
Contributor

alexdupre commented Jan 24, 2017

I've kept dispatch as default. I'm not sure if we prefer that scalaxbGenerateGigahorseClient automatically disable the dispatch client; currently it doesn't, so you have to set scalaxbGenerateDispatchClient := false and scalaxbGenerateGigahorseClient := true to generate the Gigahorse clients.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jan 24, 2017

Owner

wow. Thank you very much for this! Instead of Booleans what do you think about defining sealed trait HttpClientType or something like that?

Owner

eed3si9n commented Jan 24, 2017

wow. Thank you very much for this! Instead of Booleans what do you think about defining sealed trait HttpClientType or something like that?

@gabro

This comment has been minimized.

Show comment
Hide comment
@gabro

gabro Jan 25, 2017

Cool! Does this enable supporting scala 2.12 as per #408?

gabro commented Jan 25, 2017

Cool! Does this enable supporting scala 2.12 as per #408?

@gabro

This comment has been minimized.

Show comment
Hide comment
@gabro

gabro Jan 25, 2017

@alexdupre 🎉 wonderful, thanks!

gabro commented Jan 25, 2017

@alexdupre 🎉 wonderful, thanks!

@alexdupre

This comment has been minimized.

Show comment
Hide comment
@alexdupre

alexdupre Jan 25, 2017

Contributor

@eed3si9n: would you prefer to replace scalaxbGenerateDispatchClient, scalaxbGenerateDispatchAs, scalaxbGenerateGigahorseClient (or just dispatch/gigaorse client) with a single key of HttpClientType? Or such additional key, if set, would set the value of other three?

Contributor

alexdupre commented Jan 25, 2017

@eed3si9n: would you prefer to replace scalaxbGenerateDispatchClient, scalaxbGenerateDispatchAs, scalaxbGenerateGigahorseClient (or just dispatch/gigaorse client) with a single key of HttpClientType? Or such additional key, if set, would set the value of other three?

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jan 25, 2017

Owner

I think for backward compatibility we should keep any existing keys, so the second option I think would be better.

Owner

eed3si9n commented Jan 25, 2017

I think for backward compatibility we should keep any existing keys, so the second option I think would be better.

@alexdupre

This comment has been minimized.

Show comment
Hide comment
@alexdupre

alexdupre Jan 25, 2017

Contributor

I'm about to push a commit for it that simplifies the sbt setting for a single client, but I'm sure you have much more knowledge on sbt, so feel free to replace it completely as you prefer.

Contributor

alexdupre commented Jan 25, 2017

I'm about to push a commit for it that simplifies the sbt setting for a single client, but I'm sure you have much more knowledge on sbt, so feel free to replace it completely as you prefer.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jan 25, 2017

Owner

Sounds good. I'll merge this as is, and change it around later if I have to.

Owner

eed3si9n commented Jan 25, 2017

Sounds good. I'll merge this as is, and change it around later if I have to.

@eed3si9n eed3si9n merged commit 0100e33 into eed3si9n:master Jan 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment