Skip to content

Add support for Gigahorse http library.#413

Merged
eed3si9n merged 4 commits into
eed3si9n:masterfrom
alexdupre:gigahorse
Jan 25, 2017
Merged

Add support for Gigahorse http library.#413
eed3si9n merged 4 commits into
eed3si9n:masterfrom
alexdupre:gigahorse

Conversation

@alexdupre

Copy link
Copy Markdown
Contributor

I've kept dispatch as default. I'm not sure if we prefer that scalaxbGenerateGigahorseClient automatically disable the dispatch client; currently it doesn't, so you have to set scalaxbGenerateDispatchClient := false and scalaxbGenerateGigahorseClient := true to generate the Gigahorse clients.

@eed3si9n

Copy link
Copy Markdown
Owner

wow. Thank you very much for this! Instead of Booleans what do you think about defining sealed trait HttpClientType or something like that?

@gabro

gabro commented Jan 25, 2017

Copy link
Copy Markdown

Cool! Does this enable supporting scala 2.12 as per #408?

@gabro

gabro commented Jan 25, 2017

Copy link
Copy Markdown

@alexdupre 🎉 wonderful, thanks!

@alexdupre

Copy link
Copy Markdown
Contributor Author

@eed3si9n: would you prefer to replace scalaxbGenerateDispatchClient, scalaxbGenerateDispatchAs, scalaxbGenerateGigahorseClient (or just dispatch/gigaorse client) with a single key of HttpClientType? Or such additional key, if set, would set the value of other three?

@eed3si9n

Copy link
Copy Markdown
Owner

I think for backward compatibility we should keep any existing keys, so the second option I think would be better.

@alexdupre

Copy link
Copy Markdown
Contributor Author

I'm about to push a commit for it that simplifies the sbt setting for a single client, but I'm sure you have much more knowledge on sbt, so feel free to replace it completely as you prefer.

@eed3si9n

Copy link
Copy Markdown
Owner

Sounds good. I'll merge this as is, and change it around later if I have to.

@eed3si9n eed3si9n merged commit 0100e33 into eed3si9n:master Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants