Split fromAnySchemaType into smaller chunks#429
Merged
eed3si9n merged 1 commit intoeed3si9n:masterfrom Jul 3, 2017
Merged
Conversation
With big WSDLs GenProtocol's generated fromAnySchemaType function can accumulate so many case statements to exceed JVM code size limit. To prevent this, fromAnySchemaType is split into several helper functions (named fromAnySchemaTypeHelper<index>).
eed3si9n
approved these changes
Jul 3, 2017
Owner
eed3si9n
left a comment
eed3si9n
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contribution.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With big WSDLs GenProtocol's generated fromAnySchemaType function can accumulate so many case statements to exceed JVM code size limit.
To prevent this, fromAnySchemaType is split into several helper functions (named something like fromAnySchemaTypeHelper).
I see there is a PR (#411) addressing the same issue, however:
The maximum number of case statement (200) is a supposedly safe value determined by trial and error. However YMMV.