Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split fromAnySchemaType into smaller chunks #429

Merged
merged 1 commit into from Jul 3, 2017

Conversation

@fltt
Copy link
Contributor

fltt commented Jul 3, 2017

With big WSDLs GenProtocol's generated fromAnySchemaType function can accumulate so many case statements to exceed JVM code size limit.
To prevent this, fromAnySchemaType is split into several helper functions (named something like fromAnySchemaTypeHelper).

I see there is a PR (#411) addressing the same issue, however:

  1. it looks to be stale for six months now
  2. I'm unsure whether it is the same issue
  3. this fix is simpler

The maximum number of case statement (200) is a supposedly safe value determined by trial and error. However YMMV.

With big WSDLs GenProtocol's generated fromAnySchemaType function can
accumulate so many case statements to exceed JVM code size limit.
To prevent this, fromAnySchemaType is split into several helper
functions (named fromAnySchemaTypeHelper<index>).
Copy link
Owner

eed3si9n left a comment

LGTM.
Thanks for the contribution.

@eed3si9n eed3si9n merged commit b2c43c9 into eed3si9n:master Jul 3, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eed3si9n eed3si9n mentioned this pull request Jul 3, 2017
@fltt fltt deleted the fltt:split-long-fromanyschematype branch Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.