Skip to content

Don't throw exception on http status code != 200 to allow Fault parsing. #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2017
Merged

Don't throw exception on http status code != 200 to allow Fault parsing. #444

merged 1 commit into from
Oct 18, 2017

Conversation

alexdupre
Copy link
Contributor

No description provided.

@alexdupre
Copy link
Contributor Author

The tests failed for a completely unrelated reason, the proposed change is straightforward and quite important.

@eed3si9n
Copy link
Owner

Let me restart the Travis job and see if the remote service is up again.

@eed3si9n eed3si9n merged commit 47054e0 into eed3si9n:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexdupre @eed3si9n