New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw exception on http status code != 200 to allow Fault parsing. #444

Merged
merged 1 commit into from Oct 18, 2017

Conversation

Projects
None yet
2 participants
@alexdupre
Contributor

alexdupre commented Sep 22, 2017

No description provided.

@alexdupre

This comment has been minimized.

Show comment
Hide comment
@alexdupre

alexdupre Oct 10, 2017

Contributor

The tests failed for a completely unrelated reason, the proposed change is straightforward and quite important.

Contributor

alexdupre commented Oct 10, 2017

The tests failed for a completely unrelated reason, the proposed change is straightforward and quite important.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Oct 10, 2017

Owner

Let me restart the Travis job and see if the remote service is up again.

Owner

eed3si9n commented Oct 10, 2017

Let me restart the Travis job and see if the remote service is up again.

@eed3si9n eed3si9n merged commit 47054e0 into eed3si9n:master Oct 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment