Generate a default value for class parameters of anyAttribute#470
Merged
eed3si9n merged 2 commits intoeed3si9n:masterfrom Mar 19, 2018
Merged
Generate a default value for class parameters of anyAttribute#470eed3si9n merged 2 commits intoeed3si9n:masterfrom
anyAttribute#470eed3si9n merged 2 commits intoeed3si9n:masterfrom
Conversation
Normally, generated classes have an `attributes: Map` parameter that defaults to an empty Map. However, a map generated for `anyAttribute` wasn't given a default value. This commit adds a default value in that case. There is also the trivial improvement of using `Map.empty` instead of `Map.apply()`.
It doesn't affect anything but just for the sake of consistency.
eed3si9n
approved these changes
Mar 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually, generated classes have an
attributes: Mapparameter that defaults to an empty Map. However, a map generated foranyAttributewasn't given a default value.This commit adds a default value in that case.
There is also the trivial improvement of using
Map.emptyinstead ofMap.apply().