Skip to content

Use sealed traits for enums#479

Merged
eed3si9n merged 1 commit into
eed3si9n:masterfrom
mrdziuban:enum-sealed-trait
Aug 16, 2018
Merged

Use sealed traits for enums#479
eed3si9n merged 1 commit into
eed3si9n:masterfrom
mrdziuban:enum-sealed-trait

Conversation

@mrdziuban
Copy link
Copy Markdown
Contributor

@mrdziuban mrdziuban commented Aug 16, 2018

This has two main benefits:

  • Allows exhaustive pattern matches on enums
  • Allows observation of all members at compile time using knownDirectSubclasses

eed3si9n
eed3si9n approved these changes Aug 16, 2018
View reviewed changes
Copy link
Copy Markdown
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@mrdziuban
Copy link
Copy Markdown
Contributor Author

mrdziuban commented Aug 16, 2018

Thanks @eed3si9n, it looks like the tests failed because the SOAP service for getting stock quotes was shut down.

@eed3si9n eed3si9n merged commit 3c8f978 into eed3si9n:master Aug 16, 2018
@mrdziuban mrdziuban deleted the enum-sealed-trait branch August 16, 2018 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mrdziuban @eed3si9n