New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sealed traits for enums #479

Merged
merged 1 commit into from Aug 16, 2018

Conversation

Projects
None yet
2 participants
@mrdziuban
Contributor

mrdziuban commented Aug 16, 2018

This has two main benefits:

  • Allows exhaustive pattern matches on enums
  • Allows observation of all members at compile time using knownDirectSubclasses
@eed3si9n

LGTM pending CI

@mrdziuban

This comment has been minimized.

Show comment
Hide comment
@mrdziuban

mrdziuban Aug 16, 2018

Contributor

Thanks @eed3si9n, it looks like the tests failed because the SOAP service for getting stock quotes was shut down.

Contributor

mrdziuban commented Aug 16, 2018

Thanks @eed3si9n, it looks like the tests failed because the SOAP service for getting stock quotes was shut down.

@eed3si9n eed3si9n merged commit 3c8f978 into eed3si9n:master Aug 16, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@mrdziuban mrdziuban deleted the mrdziuban:enum-sealed-trait branch Aug 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment