Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equals called on a string and option[string] #485

Merged
merged 1 commit into from Nov 20, 2018
Merged

Equals called on a string and option[string] #485

merged 1 commit into from Nov 20, 2018

Conversation

lespea
Copy link
Contributor

@lespea lespea commented Nov 19, 2018

Should use contains

eed3si9n
eed3si9n approved these changes Nov 20, 2018
View reviewed changes
Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit bbd95d3 into eed3si9n:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lespea @eed3si9n