Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format BigDecimal Attributes properly. #505

Merged
merged 1 commit into from Apr 16, 2019

Conversation

@tOverney
Copy link
Contributor

commented Apr 8, 2019

This builds on #483.
The case is not solved when toXML is called for a generated class and one of its attribute is a BigDecimal.

(sorry, I didn't manage to do it over the weekend in the end!)

@tOverney

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Crap, test is too easy, it only generates writesChildNode still need to do some work on it...

@tOverney

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2019

Test now fixed, @eed3si9n I believe this should be ready for your eyes ;)

Properly Format BigDecimal Attributes.
This builds on #483.
The case is not solved when `toXML` is called for a generated class and one of its attribute is a BigDecimal.
@eed3si9n
Copy link
Owner

left a comment

Thanks!

@eed3si9n eed3si9n merged commit 92e8a51 into eed3si9n:master Apr 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.