Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13 support in app #514

Merged
merged 15 commits into from
Aug 26, 2019
Merged

Conversation

jtjeferreira
Copy link
Contributor

@jtjeferreira jtjeferreira commented Jul 22, 2019

@jtjeferreira
Copy link
Contributor Author

I think this is blocked on dispatch/reboot#210

@eed3si9n
Copy link
Owner

@jtjeferreira Thanks for this contribution. I am looking forward to getting green. Hopefully Dispatch will get 2.13 soon now that Unfiltered is out? http://repo1.maven.org/maven2/ws/unfiltered/unfiltered_2.13/0.10.0-M4/

@MariosPapasofokli
Copy link

Copy link
Contributor Author

@jtjeferreira jtjeferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eed3si9n can I have a review? I had to upgrade a few dependencies, so maybe we should bump the version?

sys.error("At least one line of code is required.")
val s = settings(outdir, classpath, usecurrentcp, unchecked,
deprecation, feature, fatalWarnings)
val main = new IMain(s, new scala.tools.nsc.interpreter.shell.ReplReporterImpl(s)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to duplicate this file, because of the change is this line

Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eed3si9n eed3si9n merged commit 63c8c71 into eed3si9n:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants