Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 2.13 support in app #514

Merged
merged 15 commits into from Aug 26, 2019

Conversation

@jtjeferreira
Copy link
Contributor

commented Jul 22, 2019

[ ] dispatch/reboot#210

we need to fork integration test because scala/scala-parser-combinators#197
instead of forking use different version of parsercombinators
@jtjeferreira jtjeferreira force-pushed the jtjeferreira:scala-2.13-in-app branch from f221668 to 826959f Jul 23, 2019
@jtjeferreira

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

I think this is blocked on dispatch/reboot#210

@eed3si9n

This comment has been minimized.

Copy link
Owner

commented Jul 25, 2019

@jtjeferreira Thanks for this contribution. I am looking forward to getting green. Hopefully Dispatch will get 2.13 soon now that Unfiltered is out? http://repo1.maven.org/maven2/ws/unfiltered/unfiltered_2.13/0.10.0-M4/

@MariosPapasofokli

This comment has been minimized.

fix tests to be class instead of object (see etorreborre/specs2#757)
Copy link
Contributor Author

left a comment

@eed3si9n can I have a review? I had to upgrade a few dependencies, so maybe we should bump the version?

sys.error("At least one line of code is required.")
val s = settings(outdir, classpath, usecurrentcp, unchecked,
deprecation, feature, fatalWarnings)
val main = new IMain(s, new scala.tools.nsc.interpreter.shell.ReplReporterImpl(s)) {

This comment has been minimized.

Copy link
@jtjeferreira

jtjeferreira Aug 26, 2019

Author Contributor

I had to duplicate this file, because of the change is this line

Copy link
Owner

left a comment

LGTM

@eed3si9n eed3si9n merged commit 63c8c71 into eed3si9n:master Aug 26, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.