Split fromString method for big enums that would otherwise not compile - #517
Merged
Conversation
|
Had the same problem, supporting this fix. |
Contributor
Author
|
I don't know why the travis builds timed out. |
eed3si9n
approved these changes
Jun 28, 2020
Owner
|
Sorry about the late response. I'm merging this now. |
|
scalaxb 1.7.4 is OK Will try to create a test case. |
Contributor
Author
|
That is a warning and you have -Werror or -Xfatal-warnings set right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With big enums the generated fromString methods exceed the allowed method size and won't compile.
This PR splits the fromString method into multiple private methods with 500 lines each.