Skip to content

Split fromString method for big enums that would otherwise not compile - #517

Merged
eed3si9n merged 1 commit into
eed3si9n:masterfrom
lhns:big-enums
Jun 28, 2020
Merged

Split fromString method for big enums that would otherwise not compile#517
eed3si9n merged 1 commit into
eed3si9n:masterfrom
lhns:big-enums

Conversation

@lhns

@lhns lhns commented Oct 23, 2019

Copy link
Copy Markdown
Contributor

With big enums the generated fromString methods exceed the allowed method size and won't compile.
This PR splits the fromString method into multiple private methods with 500 lines each.

grafik

@Th3Falc0n

Copy link
Copy Markdown

Had the same problem, supporting this fix.

@lhns

lhns commented Nov 5, 2019

Copy link
Copy Markdown
Contributor Author

I don't know why the travis builds timed out.

@eed3si9n

Copy link
Copy Markdown
Owner

Sorry about the late response. I'm merging this now.

@eed3si9n
eed3si9n merged commit 6ede62b into eed3si9n:master Jun 28, 2020
@eed3si9n eed3si9n changed the title Support for big Enums Split fromString method for big enums that would otherwise not compile Jun 28, 2020
@mirelon

mirelon commented Aug 6, 2021

Copy link
Copy Markdown

PartialFunction[Any is causing a compile error when parsing Seq[String]

non-variable type argument String in type pattern Seq[String] (the underlying of Seq[String]) is unchecked since it is eliminated by erasure

scalaxb 1.7.4 is OK
scalaxb 1.7.5 is failing

Will try to create a test case.

@lhns

lhns commented Aug 6, 2021

Copy link
Copy Markdown
Contributor Author

That is a warning and you have -Werror or -Xfatal-warnings set right?
Weird that the compiler doesn't warn about this before the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants