Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split fromString method for big enums that would otherwise not compile #517

Merged
merged 1 commit into from Jun 28, 2020

Conversation

lhns
Copy link
Contributor

@lhns lhns commented Oct 23, 2019

With big enums the generated fromString methods exceed the allowed method size and won't compile.
This PR splits the fromString method into multiple private methods with 500 lines each.

grafik

@Th3Falc0n
Copy link

@Th3Falc0n Th3Falc0n commented Oct 23, 2019

Had the same problem, supporting this fix.

@lhns
Copy link
Contributor Author

@lhns lhns commented Nov 5, 2019

I don't know why the travis builds timed out.

@eed3si9n
Copy link
Owner

@eed3si9n eed3si9n commented Jun 28, 2020

Sorry about the late response. I'm merging this now.

@eed3si9n eed3si9n merged commit 6ede62b into eed3si9n:master Jun 28, 2020
1 check passed
@eed3si9n eed3si9n changed the title Support for big Enums Split fromString method for big enums that would otherwise not compile Jun 28, 2020
@mirelon
Copy link

@mirelon mirelon commented Aug 6, 2021

PartialFunction[Any is causing a compile error when parsing Seq[String]

non-variable type argument String in type pattern Seq[String] (the underlying of Seq[String]) is unchecked since it is eliminated by erasure

scalaxb 1.7.4 is OK
scalaxb 1.7.5 is failing

Will try to create a test case.

@lhns
Copy link
Contributor Author

@lhns lhns commented Aug 6, 2021

That is a warning and you have -Werror or -Xfatal-warnings set right?
Weird that the compiler doesn't warn about this before the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants