Removing multiarg infix syntax warnings introduced with Scala 2.13.3 #531
Merged
eed3si9n merged 3 commits intoJun 27, 2020
Merged
Conversation
Owner
|
Thanks for the contribution! |
Owner
|
Not sure which one is causing it but the following error looks suspicious tmp/xmlprotocol.scala:584: error: illegal start of simple expression
(any(List(x, , =, >, , L, i, s, t, (, N, o, n, e, ), , c, o, n, t, a, i, n, s, , x, ., n, a, m, e, s, p, a, c, e))) ~
^
tmp/xmlprotocol.scala:623: error: ')' expected but '}' found.
}
^
tmp/xmlprotocol.scala:584: error: illegal start of simple expression
(any(List(x, , =, >, , L, i, s, t, (, N, o, n, e, ), , c, o, n, t, a, i, n, s, , x, ., n, a, m, e, s, p, a, c, e))) ~
^
tmp/xmlprotocol.scala:623: error: ')' expected but '}' found.
}
^
[info] GeneralTest
[info] ! general.scala file must compile together with GeneralUsage.scala
[error] RuntimeException: : Error compiling: tmp/GeneralUsage.scala,tmp/general.scala,tmp/xmlmime.scala,tmp/general_import.scala,tmp/xmlprotocol.scala,tmp/scalaxb.scala (CompilerMatcher.scala:99)
[error] CompilerMatcher$$anon$2.apply(CompilerMatcher.scala:99)
[error] GeneralTest$$anonfun$1.apply(GeneralTest.scala:29)
[error] GeneralTest$$anonfun$1.apply(GeneralTest.scala:29)
[info]
[info] ! general.scala file must compile together with CustomizationUsage.scala
[error] RuntimeException: : Error compiling: tmp/CustomizationUsage.scala,tmp/general.scala,tmp/xmlmime.scala,tmp/general_import.scala,tmp/xmlprotocol.scala,tmp/scalaxb.scala (CompilerMatcher.scala:99)
[error] CompilerMatcher$$anon$2.apply(CompilerMatcher.scala:99)
[error] GeneralTest$$anonfun$2.apply(GeneralTest.scala:35)
[error] GeneralTest$$anonfun$2.apply(GeneralTest.scala:35) |
Contributor
Author
|
Yep, there where 2 cases where format calls where done with "tuple of one" and then running mkString before using result as argument for format method. When I added just simple dot it made first format call and then mkString call for string. Added extra parenthesis and now I did manage to run tests locally also and didn't have to wait travis for report |
eed3si9n
approved these changes
Jun 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #530