Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing multiarg infix syntax warnings introduced with Scala 2.13.3 #531

Merged

Conversation

margussipria
Copy link
Contributor

@margussipria margussipria commented Jun 26, 2020

Fixes issue #530

@eed3si9n
Copy link
Owner

eed3si9n commented Jun 26, 2020

Thanks for the contribution!

@eed3si9n
Copy link
Owner

eed3si9n commented Jun 26, 2020

Not sure which one is causing it but the following error looks suspicious

tmp/xmlprotocol.scala:584: error: illegal start of simple expression
      (any(List(x,  , =, >,  , L, i, s, t, (, N, o, n, e, ),  , c, o, n, t, a, i, n, s,  , x, ., n, a, m, e, s, p, a, c, e))) ~
                    ^
tmp/xmlprotocol.scala:623: error: ')' expected but '}' found.
  }
  ^
tmp/xmlprotocol.scala:584: error: illegal start of simple expression
      (any(List(x,  , =, >,  , L, i, s, t, (, N, o, n, e, ),  , c, o, n, t, a, i, n, s,  , x, ., n, a, m, e, s, p, a, c, e))) ~
                    ^
tmp/xmlprotocol.scala:623: error: ')' expected but '}' found.
  }
  ^
[info] GeneralTest
[info] ! general.scala file must compile together with GeneralUsage.scala
[error]  RuntimeException: : Error compiling: tmp/GeneralUsage.scala,tmp/general.scala,tmp/xmlmime.scala,tmp/general_import.scala,tmp/xmlprotocol.scala,tmp/scalaxb.scala  (CompilerMatcher.scala:99)
[error] CompilerMatcher$$anon$2.apply(CompilerMatcher.scala:99)
[error] GeneralTest$$anonfun$1.apply(GeneralTest.scala:29)
[error] GeneralTest$$anonfun$1.apply(GeneralTest.scala:29)
[info] 
[info] ! general.scala file must compile together with CustomizationUsage.scala
[error]  RuntimeException: : Error compiling: tmp/CustomizationUsage.scala,tmp/general.scala,tmp/xmlmime.scala,tmp/general_import.scala,tmp/xmlprotocol.scala,tmp/scalaxb.scala  (CompilerMatcher.scala:99)
[error] CompilerMatcher$$anon$2.apply(CompilerMatcher.scala:99)
[error] GeneralTest$$anonfun$2.apply(GeneralTest.scala:35)
[error] GeneralTest$$anonfun$2.apply(GeneralTest.scala:35)

@margussipria
Copy link
Contributor Author

margussipria commented Jun 27, 2020

Yep, there where 2 cases where format calls where done with "tuple of one" and then running mkString before using result as argument for format method. When I added just simple dot it made first format call and then mkString call for string.

Added extra parenthesis and now I did manage to run tests locally also and didn't have to wait travis for report

@eed3si9n eed3si9n merged commit f6b7819 into eed3si9n:master Jun 27, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants