/ scalaxb Public
Ensure constant time random access in ElemNameSeqReader. #544
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Parsing large sequences has performance issues : I traced it back to a quadratic behavior in a loop using
ElemNameSeqReader's use of
isDefinedAtpresuppose constant time random access in its internal
seq, but it ends up doing it on a
List, I believe fed from
AnyElemNameParser. This diff both builds a
Vectorinstead of a
AnyElemNameParser, and enforces a
ElemNameSeqReaderinternals. This is successful in fixing the performance issue we've observed at my company.
Let me know if you need me to do something else in the pull request (do I have to do something special to update