Ensure constant time random access in ElemNameSeqReader.#544
Merged
eed3si9n merged 1 commit intoNov 30, 2020
Conversation
Owner
|
@omatzcoveo Thanks for the contribution. Could you fix the failing integration tests please? |
159e645 to
1065537
Compare
eed3si9n
approved these changes
Nov 28, 2020
Contributor
Author
|
Last friday I opted to reduce the scope of the change in order not to have any impact on tests and such, and only keep the important bit that removes the quadratic behavior. Thanks! |
Owner
|
Nicely done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
Parsing large sequences has performance issues : I traced it back to a quadratic behavior in a loop using
ElemNameSeqReader.ElemNameSeqReader's use ofisDefinedAtpresuppose constant time random access in its internalseq, but it ends up doing it on aList, I believe fed fromAnyElemNameParser. This diff both builds aVectorinstead of aListfromAnyElemNameParser, and enforces aVectorinElemNameSeqReaderinternals. This is successful in fixing the performance issue we've observed at my company.Let me know if you need me to do something else in the pull request (do I have to do something special to update
src_managed/scalaxb/scalaxb.scala?).Thanks