Trim most XSD types that have whitespace = collapse #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like it's been a while regenerating that but iirc you should be able to uncomment some of the lines on: |
The XSD spec says to ignore white space around decimal, boolean and other types. However, scalaxb currently only trims URIs. This commit adds the ability to ignore whitespace to other types, and adds a test for this. Fixes eed3si9n#554.
|
I've manually patched |
|
Thanks a lot for merging! There have been a fair few commits since the last 1.8.0 release. Would it be possible to do a bugfix release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
The XSD spec says to ignore white space around decimal, boolean and
other types. However, scalaxb currently only trims URIs.
This commit adds the ability to ignore whitespace to other types, and
adds a test for this.
Fixes #554.
sbt testandsbt packagedidn't seem to touch that file. Any hints? :-)