Skip to content

Trim most XSD types that have whitespace = collapse - #556

Merged
eed3si9n merged 1 commit into
eed3si9n:masterfrom
jypma:trim_numbers
Feb 23, 2021
Merged

Trim most XSD types that have whitespace = collapse#556
eed3si9n merged 1 commit into
eed3si9n:masterfrom
jypma:trim_numbers

Conversation

@jypma

@jypma jypma commented Feb 22, 2021

Copy link
Copy Markdown
Contributor

The XSD spec says to ignore white space around decimal, boolean and
other types. However, scalaxb currently only trims URIs.

This commit adds the ability to ignore whitespace to other types, and
adds a test for this.

Fixes #554.

  • I suppose the pre-generated scalaxb.scala also needs to be updated, but I couldn't find out how to re-generate it. sbt test and sbt package didn't seem to touch that file. Any hints? :-)

@eed3si9n

Copy link
Copy Markdown
Owner

I feel like it's been a while regenerating that but iirc you should be able to uncomment some of the lines on:

The XSD spec says to ignore white space around decimal, boolean and
other types. However, scalaxb currently only trims URIs.

This commit adds the ability to ignore whitespace to other types, and
adds a test for this.

Fixes eed3si9n#554.
@jypma

jypma commented Feb 23, 2021

Copy link
Copy Markdown
Contributor Author

I've manually patched scalaxb.scala with the same changes.

@eed3si9n eed3si9n left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n
eed3si9n merged commit d83c478 into eed3si9n:master Feb 23, 2021
@jypma
jypma deleted the trim_numbers branch February 26, 2021 15:40
@jypma

jypma commented Feb 26, 2021

Copy link
Copy Markdown
Contributor Author

Thanks a lot for merging!

There have been a fair few commits since the last 1.8.0 release. Would it be possible to do a bugfix release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parsing xsd:decimal does not honor xs:whitespace = collapse

2 participants