-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to scala-xml and scala-parser-combinators 2.x versions #589
Upgrade to scala-xml and scala-parser-combinators 2.x versions #589
Conversation
eaf89bb
to
c915f64
Compare
Thanks @eed3si9n, updated to upgrade the |
Looks like my GitHub Actions have gone stale somehow since tests are not running on this PR? |
Yeah that's strange, not sure why. Let me know if I can do anything to help |
I know workflows go idle after 60 days if there has been no action. Maybe that's what's happening here? |
Yea, maybe because I have a weekly cron section in the workflow to catch changes to outside resource? Does it wake up after making some commits? |
Can you manually trigger it? There might be a "re-enable" in the actions view. |
Removing cron job seems to fix it - #592 |
c915f64
to
8fb1fa7
Compare
👍 just cherry-picked the commit from #592 and also updated to sbt 1.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@mrdziuban Given sbt 1.8.0 still uses parser-combinators 1.x, we might want to hold off on bumping that to 2.x to avoid yet another dependency multiverse issue. |
Here's my PR for this - #593 |
This updates the dependency on
scala-xml
to2.1.0
for scala 2.13 andscala-parser-combinators
to2.1.1
for scala 2.12 and 2.13.As a side effect, I also removed
sbt-nocomma
since it has a dependency onscalatest:3.0.4
which depends onscala-xml:1.0.5
. It looks like if a new version ofsbt-nocomma
is released with the change from sbt/sbt-nocomma#7 then this wouldn't be necessary.