Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to scala-xml and scala-parser-combinators 2.x versions #589

Merged
merged 6 commits into from
Nov 11, 2022

Conversation

mrdziuban
Copy link
Contributor

This updates the dependency on scala-xml to 2.1.0 for scala 2.13 and scala-parser-combinators to 2.1.1 for scala 2.12 and 2.13.

As a side effect, I also removed sbt-nocomma since it has a dependency on scalatest:3.0.4 which depends on scala-xml:1.0.5. It looks like if a new version of sbt-nocomma is released with the change from sbt/sbt-nocomma#7 then this wouldn't be necessary.

@eed3si9n
Copy link
Owner

eed3si9n commented Nov 5, 2022

@mrdziuban mrdziuban force-pushed the scala-xml-parser-combinators-2.x branch from eaf89bb to c915f64 Compare November 7, 2022 17:40
@mrdziuban
Copy link
Contributor Author

Thanks @eed3si9n, updated to upgrade the sbt-nocomma dependency instead of remove it

@eed3si9n
Copy link
Owner

eed3si9n commented Nov 7, 2022

Looks like my GitHub Actions have gone stale somehow since tests are not running on this PR?

@mrdziuban
Copy link
Contributor Author

Yeah that's strange, not sure why. Let me know if I can do anything to help

@ckipp01
Copy link
Contributor

ckipp01 commented Nov 11, 2022

Looks like my GitHub Actions have gone stale somehow since tests are not running on this PR?

I know workflows go idle after 60 days if there has been no action. Maybe that's what's happening here?

@eed3si9n
Copy link
Owner

Yea, maybe because I have a weekly cron section in the workflow to catch changes to outside resource? Does it wake up after making some commits?

@ckipp01
Copy link
Contributor

ckipp01 commented Nov 11, 2022

Yea, maybe because I have a weekly cron section in the workflow to catch changes to outside resource? Does it wake up after making some commits?

Can you manually trigger it? There might be a "re-enable" in the actions view.

@eed3si9n
Copy link
Owner

Removing cron job seems to fix it - #592

@mrdziuban mrdziuban force-pushed the scala-xml-parser-combinators-2.x branch from c915f64 to 8fb1fa7 Compare November 11, 2022 17:35
@mrdziuban
Copy link
Contributor Author

👍 just cherry-picked the commit from #592 and also updated to sbt 1.8.0

Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit c853931 into eed3si9n:develop Nov 11, 2022
@mrdziuban mrdziuban deleted the scala-xml-parser-combinators-2.x branch November 11, 2022 18:01
@eed3si9n
Copy link
Owner

@mrdziuban Given sbt 1.8.0 still uses parser-combinators 1.x, we might want to hold off on bumping that to 2.x to avoid yet another dependency multiverse issue.

@eed3si9n
Copy link
Owner

Here's my PR for this - #593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants