Enumerate all transitive self types in generated SOAP bindings#595
Merged
Conversation
Problem
-------
In Scala 3 the self type must enumerate all transitive self types. That
means that generated code like this is rejected by the Scala 3
compiler:
```scala
trait HttpClients {}
trait Soap11Clients { this: HttpClients => }
trait FooSoapBindings { this: Soap11Clients => }
```
It complains with:
```
[error] -- [E058] Type Mismatch Error: Test.scala:6:8
[error] 6 | trait FooSoapBindings { this: Soap11Clients => } // error
[error] | ^
[error] |missing requirement: self type Soap11Clients & FooSoapBindings of trait FooSoapBindings does not conform to self type HttpClients
[error] |of required trait Soap11Clients
```
Solution
--------
The solution is to add `HttpClients` (or `scalaxb.HttpClientsAsync`) to
the self type of the generated SOAP bindings. Scala 2 is still happy
with this change and Scala 3 is now able to compile the generated
bindings.
eed3si9n
approved these changes
Feb 11, 2023
Contributor
Author
|
Thanks for releasing this so quickly @eed3si9n! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Scala 3 the self type must enumerate all transitive self types. That means that generated code like this is rejected by the Scala 3 compiler:
It complains with:
Solution
The solution is to add
scalaxb.HttpClients(orscalaxb.HttpClientsAsync) to the self type of the generated SOAP bindings. Scala 2 is still happy with this change and Scala 3 is now able to compile the generated bindings.I've tested these changes by publishing this branch locally and by using the local sbt-scalaxb 1.9.1-SNAPSHOT plugin to generate code that was then compiled with Scala 3.2.2. It compiled successfully with both
scalaxbAsync := trueandfalse.Closes: #557