-
Notifications
You must be signed in to change notification settings - Fork 159
http4s client + tagless final style generation #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also include an http4s client.
5eeb222
to
0b167dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zarthross!
@eed3si9n No rush, but do you have an idea on when you might merge and release this change? I'm trying to determine if I need to cut an internal release or not in order to use this feature and knowing what your expected timeline is could save me some time 😄 |
I'll try to release today or tomorrow. |
So I released 1.10.0, but it doesn't seem to generate http4s client when I set to the following: import Dependencies._
ThisBuild / organization := "com.example"
ThisBuild / version := "0.1.0-SNAPSHOT"
ThisBuild / scalaVersion := "2.13.10"
lazy val scalaXml = "org.scala-lang.modules" %% "scala-xml" % "1.3.0"
lazy val scalaParser = "org.scala-lang.modules" %% "scala-parser-combinators" % "1.1.2"
lazy val jaxbApi = "javax.xml.bind" % "jaxb-api" % "2.3.0"
lazy val root = (project in file("."))
.enablePlugins(ScalaxbPlugin)
.settings(
name := "soap",
libraryDependencies ++= Seq(scalaXml, scalaParser, jaxbApi),
Compile / scalaxb / scalaxbPackageName := "generated",
Compile / scalaxb / scalaxbGenerateDispatchClient := false,
Compile / scalaxb / scalaxbGenerateHttp4sClient := true,
)
|
Thanks for releasing it!!! Looks like I missed an edge case, you need to explicitly set the scalaxbHttpClientStyle := HttpClientStyle.Tagless, |
Here's how I followed up - #597 |
What this PR Does:
TODO
- [ ] Update Docs(I'll do this if you tell me how 😆 )