http4s client + tagless final style generation#596
Merged
Conversation
Also include an http4s client.
5eeb222 to
0b167dd
Compare
Contributor
Author
|
@eed3si9n No rush, but do you have an idea on when you might merge and release this change? I'm trying to determine if I need to cut an internal release or not in order to use this feature and knowing what your expected timeline is could save me some time 😄 |
Owner
|
I'll try to release today or tomorrow. |
Owner
|
So I released 1.10.0, but it doesn't seem to generate http4s client when I set to the following: import Dependencies._
ThisBuild / organization := "com.example"
ThisBuild / version := "0.1.0-SNAPSHOT"
ThisBuild / scalaVersion := "2.13.10"
lazy val scalaXml = "org.scala-lang.modules" %% "scala-xml" % "1.3.0"
lazy val scalaParser = "org.scala-lang.modules" %% "scala-parser-combinators" % "1.1.2"
lazy val jaxbApi = "javax.xml.bind" % "jaxb-api" % "2.3.0"
lazy val root = (project in file("."))
.enablePlugins(ScalaxbPlugin)
.settings(
name := "soap",
libraryDependencies ++= Seq(scalaXml, scalaParser, jaxbApi),
Compile / scalaxb / scalaxbPackageName := "generated",
Compile / scalaxb / scalaxbGenerateDispatchClient := false,
Compile / scalaxb / scalaxbGenerateHttp4sClient := true,
)
|
Contributor
Author
|
Thanks for releasing it!!! Looks like I missed an edge case, you need to explicitly set the scalaxbHttpClientStyle := HttpClientStyle.Tagless, |
Owner
|
Here's how I followed up - #597 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR Does:
TODO
- [ ] Update Docs(I'll do this if you tell me how 😆 )