Skip to content

use ClassTag instead of Manifest #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2023
Merged

use ClassTag instead of Manifest #608

merged 1 commit into from
Oct 4, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Oct 3, 2023

prepare Scala 3

eed3si9n
eed3si9n approved these changes Oct 4, 2023
View reviewed changes
Copy link
Owner

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably ok. I feel like ClassTag had thread concurrency issues more than Manifest, but I could be misremembering things?

@eed3si9n eed3si9n merged commit 55af826 into eed3si9n:develop Oct 4, 2023
@xuwei-k xuwei-k deleted the ClassTag-Manifest branch October 4, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuwei-k @eed3si9n