From 399d272a354b3cf98b60cea05c83ee03fcf947f0 Mon Sep 17 00:00:00 2001 From: Chris Strom Date: Sat, 21 May 2016 14:20:00 -0400 Subject: [PATCH] More accurate test skip messages For window.location changes that we can't currently test with the test package. Paired with @terrasea #102 --- test/full/copy_dialog_test.dart | 7 ++----- test/full_test.dart | 7 ++----- 2 files changed, 4 insertions(+), 10 deletions(-) diff --git a/test/full/copy_dialog_test.dart b/test/full/copy_dialog_test.dart index 74ed088..ebda7a9 100644 --- a/test/full/copy_dialog_test.dart +++ b/test/full/copy_dialog_test.dart @@ -245,11 +245,8 @@ copy_dialog_tests() { }); test('leaves snapshot mode', () { - expect( - window.location.hash, - '' - ); - }, skip: "Unsure that it's possible to test this"); + expect(window.location.search, ''); + }, skip: "Cannot test window.location changes with current test runner"); }); } diff --git a/test/full_test.dart b/test/full_test.dart index f8fdb58..1b0e493 100644 --- a/test/full_test.dart +++ b/test/full_test.dart @@ -212,11 +212,8 @@ full_tests() { queryWithContent('button', 'Leave Snapshot Mode'). click(); - expect( - window.location.hash, - '' - ); - }, skip: "Unsure if it's possible to test this"); + expect(window.location.search, ''); + }, skip: 'Cannot test window.location changes with current test runner'); test("menu only includes Open, Make a Copy, and Help", (){ helpers.click('button', text: '☰');