Merge pull request #1 from santiaago/master

eee-c · eee-c · commit e133dc10a926 · 2013-05-05T21:18:32.000-07:00
Onchange preview callback
diff --git a/lib/editor.dart b/lib/editor.dart
@@ -29,6 +29,7 @@ class Editor {
     this._ace.setValue(data, -1);
     this._ace.focus();
     this.updatePreview();
+    _ace.getSession().on('change',new js.Callback.many((e,a)=>this.updatePreview()));
   }
 
   // worry about waitForAce?
@@ -53,7 +54,7 @@ class Editor {
 
   removePreview() {
     while (this._preview_el.children.length > 0) {
-      this._preview_el.removeChild(this._preview_el.firstChild);
+      	  this._preview_el.children.first.remove();
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ class Editor {`
`29`	`29`	`this._ace.setValue(data, -1);`
`30`	`30`	`this._ace.focus();`
`31`	`31`	`this.updatePreview();`
	`32`	`+ _ace.getSession().on('change',new js.Callback.many((e,a)=>this.updatePreview()));`
`32`	`33`	`}`
`33`	`34`
`34`	`35`	`// worry about waitForAce?`
`@@ -53,7 +54,7 @@ class Editor {`
`53`	`54`
`54`	`55`	`removePreview() {`
`55`	`56`	`while (this._preview_el.children.length > 0) {`
`56`		`- this._preview_el.removeChild(this._preview_el.firstChild);`
	`57`	`+ this._preview_el.children.first.remove();`
`57`	`58`	`}`
`58`	`59`	`}`
`59`	`60`