Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change for custom tags. The main thrust is to remove any link between the underlying CST implementation and tag implementations. That should make custom tags easier to write and understand (in particular for collections), and will allow for the CST implementation to be changed without further tag API changes.
Previously, custom tags used this sort of interface when parsing values:
The new API looks like this:
Here,
value
is either astring
,YAMLMap
orYAMLSeq
, depending on the shape of its value. A tag should verify that it's getting an instance of its expected type.onError
is a callback that takes the error message as its single argument and internally constructs aYAMLSemanticError
from it.Because mappings and sequences are now always initially resolved into their corresponding AST structures, the
parseMap
andparseSeq
exports of'yaml/util'
are also dropped.