Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer import isomorphic-git #224

Closed
knownasilya opened this issue Jun 19, 2019 · 2 comments

Comments

@knownasilya
Copy link
Contributor

commented Jun 19, 2019

ERROR in ./node_modules/globalyzer/src/index.js
Module not found: Error: Can't resolve 'path' in '/Users/ilya/sandbox/branch/node_modules/globalyzer/src'
 @ ./node_modules/globalyzer/src/index.js 1:13-28
 @ ./node_modules/isomorphic-git/dist/for-future/isomorphic-git/index.js
 @ /private/var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/broccoli-919189mGQgcEuEM0v/cache-228-bundler/staging/app.js
 @ multi /private/var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/broccoli-919189mGQgcEuEM0v/cache-228-bundler/staging/l.js /private/var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/broccoli-919189mGQgcEuEM0v/cache-228-bundler/staging/app.jsBuild Error (Bundler)

webpack returned errors to ember-auto-import


Stack Trace and Error Report: /var/folders/hq/m0d3mb8s5gd1wdbn_gsk55000000gn/T/error.dump.f8c0d592d763e6f58e768429a46559fb.log
@ef4

This comment has been minimized.

Copy link
Owner

commented Jun 19, 2019

path is a node-only, built-in package.

We had a bug where we were accidentally providing automatic polyfills for that and several other node built-in packages, but we fixed the bug. And unfortunately due to the "only one copy must win" nature of ember-auto-import, there's not much way to gracefully roll out this bugfix (apps and addons can all update independently and all of them must be prepared to deal with the new version taking over). Sorry it bit you. See also previous #218 (comment)

You can affirmatively add the polyfill like:

autoImport: {
  webpack: { 
    node: { 
      path: true 
    }
}
@knownasilya

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

Ah, I was hoping this was the issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.