Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

AMD/Node.js Build - Consistent Formatting etc. #1

Merged
merged 5 commits into from almost 2 years ago
 +1,252 36,611

2 participants

Sven Lito Eric Feminella
Sven Lito
svnlto commented

I initially started of trying to generate an AMD module as I wanted to use this with require.js.
I've ended up creating a proper build process you can use for releases and such. I've also made some other enhancements i.e. improve the way the code is formatted etc.

let me know what you think of it.

Eric Feminella
Owner

Adding AMD support has been on my todo list, though I typically include plugins with RequireJS separately via a specific loader; e.g:
define ( [
'order!vendor/jquery/1.7.1/jquery.min',
'order!vendor/underscore/1.3.1/underscore-min',
'order!vendor/backbone/0.9.1/backbone-min',
'order!vendor/backbone/plugins/backbone-eventbroker'
...
], function () {

return {
$ : jQuery.noConflict(),
_ : _.noConflict(),
Backbone : Backbone.noConflict()
...
};
});

That said, the approach is limiting for cases outside of RequireJS, such as Node, so true AMD support is certainly good to have.

The two space vs. four space tabs is more preference than anything, so those changes aren't necessary, but I'll merge them in as well.

Thanks for the contribution.

Best,
Eric

Eric Feminella efeminella merged commit 5d8717b into from
Eric Feminella efeminella closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.