Compatibility with TV browser (Chrome 47)

[johneisenheim]

Hi,
crafting an application with create-react-app, and installing effector/effector-react, in the main file and importing any effector/effector-react functions, the live preview in dev mode returns the following on Chrome 47:

Unexpected token {

effector 20.0.0/effector-react 20.0.4

Thank you

---

IssueHunt Summary

zerobias has been rewarded.

Backers (Total: $40.00)

• issuehunt ($40.00)

Submitted pull Requests

• #159 Effector20.1.0

---

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

---

IssueHunt has been backed by the following sponsors. Become a sponsor

[goodmind]

What target is it? Why so old Chrome?

[goodmind]

Doesn't CRA runs node_modules through babel?

[zerobias]

Looks like your target isn't supported some new javascript features used by the library. At the moment, the project supports nodejs LTS as the lower bound of supported versions (including browsers with similar language features support), but
it seems reasonable to support older targets as well, we can add it in next version, but I wonder, is it some specific device (TV? Tesla?) or just old Chrome?

[johneisenheim]

Hi @zerobias, yes, it is a TV.
Hi @goodmind yes, CRA runs babel.

Is it possible to understand what kind of feature is not supported? Maybe I can solve - temporally - with a polyfill.

Thank you!

[zerobias]

Probably issue related with object shorthand properties, used by our terser config, but it's hard to say without proper testing. We asked browserstack.com for help, hope we'll able to publish compatible version soon

[issuehunt-oss]

@issuehunt has funded $40.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[Laiff]

Posible problem with argument default value in function call.

May be we can specify all features used in effector for build correct list of babel plugins to transpile in concrete project?

[zerobias]

As far as I know, users unable to configure cra app, so they have to use a library as it is.
I tested on chrome 47 today, looks like we can add compatible build to next release, I just can't decide how to name this file 🤔import {createStore} from 'effector/legacy'?

[Laiff]

May be import {createStore} from 'effector/compat'

[johneisenheim]

@Laiff looks good!

[issuehunt-oss]

@zerobias has rewarded $28.00 to @zerobias. See it on IssueHunt

• 💰 Total deposit: $40.00
• 🎉 Repository reward(20%): $8.00
• 🔧 Service fee(10%): $4.00

[johneisenheim]

Hello,
First of all thank you for the fix. We have noticed that also effector-react has its compat version. In this version, it should import effector/compat, not just effector. We have experienced the problem above again, but after we imported effector/compat in node modules everything is ok! Is that correct?

[zerobias]

Hello,
First of all thank you for the fix. We have noticed that also effector-react has its compat version. In this version, it should import effector/compat, not just effector. We have experienced the problem above again, but after we imported effector/compat in node modules everything is ok! Is that correct?

Going to fix this in next release