Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with TV browser (Chrome 47) #152

Closed
johneisenheim opened this issue Jul 15, 2019 · 13 comments · Fixed by #159
Closed

Compatibility with TV browser (Chrome 47) #152

johneisenheim opened this issue Jul 15, 2019 · 13 comments · Fixed by #159
Assignees
Labels
compatibility Compatibility issues: browsers, devices, platforms 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt

Comments

@johneisenheim
Copy link

johneisenheim commented Jul 15, 2019

Issuehunt badges

Hi,
crafting an application with create-react-app, and installing effector/effector-react, in the main file and importing any effector/effector-react functions, the live preview in dev mode returns the following on Chrome 47:

Unexpected token {

effector 20.0.0/effector-react 20.0.4

Thank you


IssueHunt Summary

zerobias zerobias has been rewarded.

Backers (Total: $40.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@goodmind
Copy link
Contributor

goodmind commented Jul 15, 2019

What target is it? Why so old Chrome?

@goodmind
Copy link
Contributor

goodmind commented Jul 15, 2019

Doesn't CRA runs node_modules through babel?

@zerobias
Copy link
Member

zerobias commented Jul 15, 2019

Looks like your target isn't supported some new javascript features used by the library. At the moment, the project supports nodejs LTS as the lower bound of supported versions (including browsers with similar language features support), but
it seems reasonable to support older targets as well, we can add it in next version, but I wonder, is it some specific device (TV? Tesla?) or just old Chrome?

@johneisenheim
Copy link
Author

johneisenheim commented Jul 15, 2019

Hi @zerobias, yes, it is a TV.
Hi @goodmind yes, CRA runs babel.

Is it possible to understand what kind of feature is not supported? Maybe I can solve - temporally - with a polyfill.

Thank you!

@zerobias
Copy link
Member

zerobias commented Jul 15, 2019

Probably issue related with object shorthand properties, used by our terser config, but it's hard to say without proper testing. We asked browserstack.com for help, hope we'll able to publish compatible version soon

@zerobias zerobias self-assigned this Jul 15, 2019
@zerobias zerobias changed the title Unexpected token on Chrome 47 Compatibility with TV browser (Chrome 47) Jul 15, 2019
@zerobias zerobias added the compatibility Compatibility issues: browsers, devices, platforms label Jul 15, 2019
@issuehunt-app
Copy link

issuehunt-app bot commented Jul 16, 2019

@issuehunt has funded $40.00 to this issue.


@issuehunt-app issuehunt-app bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label Jul 16, 2019
@Laiff
Copy link
Contributor

Laiff commented Jul 16, 2019

Posible problem with argument default value in function call.

May be we can specify all features used in effector for build correct list of babel plugins to transpile in concrete project?

@zerobias
Copy link
Member

zerobias commented Jul 16, 2019

As far as I know, users unable to configure cra app, so they have to use a library as it is.
I tested on chrome 47 today, looks like we can add compatible build to next release, I just can't decide how to name this file 🤔import {createStore} from 'effector/legacy'?

@Laiff
Copy link
Contributor

Laiff commented Jul 16, 2019

May be import {createStore} from 'effector/compat'

@johneisenheim
Copy link
Author

johneisenheim commented Jul 16, 2019

@Laiff looks good!

@issuehunt-app
Copy link

issuehunt-app bot commented Jul 27, 2019

@zerobias has rewarded $28.00 to @zerobias. See it on IssueHunt

  • 💰 Total deposit: $40.00
  • 🎉 Repository reward(20%): $8.00
  • 🔧 Service fee(10%): $4.00

@issuehunt-app issuehunt-app bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Jul 27, 2019
@johneisenheim
Copy link
Author

johneisenheim commented Aug 6, 2019

Hello,
First of all thank you for the fix. We have noticed that also effector-react has its compat version. In this version, it should import effector/compat, not just effector. We have experienced the problem above again, but after we imported effector/compat in node modules everything is ok! Is that correct?

@zerobias
Copy link
Member

zerobias commented Aug 11, 2019

Hello,
First of all thank you for the fix. We have noticed that also effector-react has its compat version. In this version, it should import effector/compat, not just effector. We have experienced the problem above again, but after we imported effector/compat in node modules everything is ok! Is that correct?

Going to fix this in next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Compatibility issues: browsers, devices, platforms 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants