Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gate doesn't use domain to generate names for internal store and events #449

Closed
dimensi opened this issue Jan 27, 2021 · 1 comment
Closed
Labels
bug Something isn't working effector-react effector-react package

Comments

@dimensi
Copy link
Contributor

dimensi commented Jan 27, 2021

Hi, I pass a domain to a gate, compositeName didn't use domain name.

For example:
https://share.effector.dev/JhsYOpNO

const domain = createDomain('root')
const event = domain.createEvent()
const store = restore(event, '')
const gate = createGate({ domain })

console.log(gate.state.compositeName.fullName) // state, 

but expect root/gateName/state

@dimensi dimensi added bug Something isn't working needs triage labels Jan 27, 2021
@zerobias zerobias added effector-react effector-react package and removed needs triage labels Feb 5, 2021
@zerobias
Copy link
Member

Fixed in effector-react@21.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effector-react effector-react package
Projects
None yet
Development

No branches or pull requests

2 participants