Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The effect made with **attach** doesn't completely belong to the domain of the original effect #527

paladdins opened this issue Sep 29, 2021 · 1 comment
bug Something isn't working core effector package


Copy link

What is the current behavior:

  • The attached effect have the parent prop
  • The attached effect's compositeName.fullName does not contain the full domain names' chain

As a result I can't properly use effector-logger with redux devtools :)

Please provide the steps to reproduce and if possible a minimal demo of the problem via, or similar

What is the expected behavior:
The attached effect's compositeName.fullName contains the full domain path to itself

Which versions of effector packages, and which browser and OS are affected by this issue? Did this work in previous versions of effector?:

  • version ^21.8.12
  • every browser
@paladdins paladdins added bug Something isn't working needs triage labels Sep 29, 2021
Copy link

The attached effect correctly belongs to the domain. You can check it via onCreateEffect hook:

But another issues with defaultConfig parent and compositeName still here.

Thank you for the report

@zerobias zerobias added core effector package and removed needs triage labels Sep 29, 2021
@zerobias zerobias self-assigned this Sep 29, 2021
@zerobias zerobias added this to the effector 22.2.0 milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
bug Something isn't working core effector package
None yet

No branches or pull requests

3 participants