Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom serialized for Store #744

Merged
merged 12 commits into from
Nov 5, 2022
Merged

Add custom serialized for Store #744

merged 12 commits into from
Nov 5, 2022

Conversation

AlexandrHoroshih
Copy link
Member

@AlexandrHoroshih AlexandrHoroshih commented Jul 22, 2022

Closes #756

Conventions

@AlexandrHoroshih AlexandrHoroshih force-pushed the feat-custom-serialize branch 2 times, most recently from cae3e12 to 55b9246 Compare July 22, 2022 17:41
@sergeysova sergeysova changed the title Feat custom serialize Add custom serialized for Store Jul 24, 2022
@sergeysova sergeysova added the enhancement New feature or request label Jul 24, 2022
@AlexandrHoroshih AlexandrHoroshih marked this pull request as ready for review July 26, 2022 06:27
Copy link
Member

@zerobias zerobias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks! 👍

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

🚛 size-compare report

Comparing de01ebdf...a3e96204

File +/- Base Current +/- gzip Base gzip Current gzip
npm/effector/compat.js +1.86% 27.7 kB 28.2 kB +1.76% 11 kB 11.2 kB
npm/effector/effector.cjs.js +1.99% 24.2 kB 24.6 kB +1.91% 10.4 kB 10.6 kB
npm/effector/effector.mjs +1.98% 24.2 kB 24.7 kB +1.80% 10.4 kB 10.6 kB
npm/effector/effector.umd.js +1.99% 24.1 kB 24.6 kB +1.98% 10.4 kB 10.6 kB
Files wasn't changed
File +/- Base Current +/- gzip Base gzip Current gzip
npm/effector/babel-plugin-react.js = 6.14 kB 6.14 kB = 1.57 kB 1.57 kB
npm/effector/babel-plugin.js = 27.1 kB 27.1 kB = 5.12 kB 5.12 kB
npm/effector/fork.js = 377 B 377 B = 233 B 233 B
npm/effector/fork.mjs = 197 B 197 B = 167 B 167 B
npm/effector-react/compat.js = 8.52 kB 8.52 kB = 3.31 kB 3.31 kB
npm/effector-react/effector-react.cjs.js = 7.83 kB 7.83 kB = 3.19 kB 3.19 kB
npm/effector-react/effector-react.mjs = 7.46 kB 7.46 kB = 3.19 kB 3.19 kB
npm/effector-react/effector-react.umd.js = 8.38 kB 8.38 kB = 3.28 kB 3.28 kB
npm/effector-react/scope.js = 7.39 kB 7.39 kB = 3.08 kB 3.08 kB
npm/effector-react/scope.mjs = 7.06 kB 7.06 kB = 3.09 kB 3.09 kB
npm/effector-react/ssr.js = 571 B 571 B = 263 B 263 B
npm/effector-react/ssr.mjs = 230 B 230 B = 171 B 171 B
npm/effector-solid/effector-solid.cjs.js = 4.04 kB 4.04 kB = 1.9 kB 1.9 kB
npm/effector-solid/effector-solid.mjs = 3.83 kB 3.83 kB = 1.92 kB 1.92 kB
npm/effector-solid/effector-solid.umd.js = 4.28 kB 4.28 kB = 1.97 kB 1.97 kB
npm/effector-solid/scope.js = 3.75 kB 3.75 kB = 1.74 kB 1.74 kB
npm/effector-solid/scope.mjs = 3.5 kB 3.5 kB = 1.74 kB 1.74 kB
npm/effector-vue/compat.js = 1.79 kB 1.79 kB = 864 B 864 B
npm/effector-vue/composition.cjs.js = 4.19 kB 4.19 kB = 1.88 kB 1.88 kB
npm/effector-vue/composition.mjs = 4 kB 4 kB = 1.91 kB 1.91 kB
npm/effector-vue/effector-vue.cjs.js = 1.71 kB 1.71 kB = 832 B 832 B
npm/effector-vue/effector-vue.mjs = 1.51 kB 1.51 kB = 800 B 800 B
npm/effector-vue/effector-vue.umd.js = 1.98 kB 1.98 kB = 938 B 938 B
npm/effector-vue/ssr.cjs.js = 561 B 561 B = 346 B 346 B
npm/effector-vue/ssr.mjs = 540 B 540 B = 331 B 331 B
npm/forest/forest.cjs.js = 34.3 kB 34.3 kB = 10.6 kB 10.6 kB
npm/forest/forest.mjs = 33.6 kB 33.6 kB = 10.6 kB 10.6 kB
npm/forest/forest.umd.js = 34.5 kB 34.5 kB = 10.6 kB 10.6 kB
npm/forest/server.js = 5.79 kB 5.79 kB = 2.06 kB 2.06 kB
npm/forest/server.mjs = 5.76 kB 5.76 kB = 2.03 kB 2.03 kB

@zerobias zerobias merged commit 176c43d into master Nov 5, 2022
@zerobias zerobias deleted the feat-custom-serialize branch November 5, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom serialization for stores
3 participants