Skip to content

allow to pass primitives to combine #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 27, 2023
Merged

allow to pass primitives to combine #884

merged 2 commits into from
Apr 27, 2023

Conversation

faustienf
Copy link
Contributor

@faustienf faustienf commented Apr 2, 2023 •
edited by sergeysova
Loading

fixes #784

combine($store, 1, '2') should allow passing primitives, not only stores (docs)

image

image

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Apr 2, 2023 •
edited
Loading

‼️ Deploy request for effector-docs rejected.

Name Link
🔨 Latest commit d78b790

@faustienf
Copy link
Contributor Author

faustienf commented Apr 2, 2023 •
edited
Loading

I've found that the combine() tests don't have cases with primitives. I'll add a test case too.

p.s. done, added test case

@sergeysova sergeysova changed the title fix(784) combine typings, allow to pass primitives allow to pass primitives to combine Apr 3, 2023
@sergeysova sergeysova added the typings Typescript public type definitions issues label Apr 3, 2023
@AlexandrHoroshih AlexandrHoroshih merged commit 66bdab5 into effector:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
typings Typescript public type definitions issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ts error when using combine with primitive values
3 participants
@faustienf @sergeysova @AlexandrHoroshih