Skip to content

Improve combine batching ability - #916

Merged
zerobias merged 4 commits into
release/v23from
feat-improve-combine-batching
Jul 19, 2023
Merged

Improve combine batching ability#916
zerobias merged 4 commits into
release/v23from
feat-improve-combine-batching

Conversation

@AlexandrHoroshih

@AlexandrHoroshih AlexandrHoroshih commented Jun 8, 2023

Copy link
Copy Markdown
Member

This is a breaking change, since it changes observable behavior (for the better though)

There is a rare edge case with combine, where it triggers more than it should have, if those updates are triggered by sample

This update fixes those cases and also, basically, makes combine and sample priorities equal for an external observer, so both sample and combine are calculated in the declaration order

Important

Conventions

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@AlexandrHoroshih
AlexandrHoroshih force-pushed the feat-improve-combine-batching branch from c831484 to e9b6c4f Compare June 8, 2023 17:39
barrier priority is not public anymore
@AlexandrHoroshih
AlexandrHoroshih force-pushed the feat-improve-combine-batching branch from e9b6c4f to b026e39 Compare June 8, 2023 17:40
@zerobias zerobias added this to the effector Spacewatch 23.0.0 milestone Jun 8, 2023
@sergeysova
sergeysova changed the base branch from master to release/v23 July 6, 2023 06:33
@zerobias
zerobias merged commit 4fd2e90 into release/v23 Jul 19, 2023
@zerobias
zerobias deleted the feat-improve-combine-batching branch July 19, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants