Improve combine batching ability - #916
Merged
Merged
Conversation
|
|
75 tasks
AlexandrHoroshih
force-pushed
the
feat-improve-combine-batching
branch
from
June 8, 2023 17:39
c831484 to
e9b6c4f
Compare
AlexandrHoroshih
force-pushed
the
feat-improve-combine-batching
branch
from
June 8, 2023 17:40
e9b6c4f to
b026e39
Compare
This was referenced Jun 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change, since it changes observable behavior (for the better though)
There is a rare edge case with
combine, where it triggers more than it should have, if those updates are triggered by sampleThis update fixes those cases and also, basically, makes
combineandsamplepriorities equal for an external observer, so bothsampleandcombineare calculated in the declaration orderImportant
Conventions