Skip to content

Rule no-duplicate-on #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorkamyshev merged 15 commits into from
Dec 10, 2021
Merged

Rule no-duplicate-on #76

igorkamyshev merged 15 commits into from
Dec 10, 2021

Conversation

@igorkamyshev
Copy link
Member

@igorkamyshev igorkamyshev commented Dec 9, 2021 •
edited
Loading

fixes #71

  • TS-case
  • Docs
  • Imports

@igorkamyshev igorkamyshev marked this pull request as draft December 9, 2021 12:25
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Total Coverage: 95.93%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 81.25% 100% 92.50% 47, 48, 54, 55, 59, 60
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Total Coverage: 96.00%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 81.25% 100% 92.50% 47, 48, 54, 55, 59, 60
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

Total Coverage: 96.85%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

Total Coverage: 96.75%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.31% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 100% 100% 100%
rules/no-getState
   no-getState.js 90% 100% 95.83% 36, 37
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

Total Coverage: 96.24%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.31% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 90.91% 100% 95.74% 32, 33, 62, 63
rules/no-getState
   no-getState.js 90% 100% 95.83% 36, 37
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Dec 10, 2021

Total Coverage: 96.53%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.31% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 90% 100% 95.83% 36, 37
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@igorkamyshev igorkamyshev marked this pull request as ready for review December 10, 2021 17:29
@github-actions
Copy link

github-actions bot commented Dec 10, 2021

Total Coverage: 96.53%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.31% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 90% 100% 95.83% 36, 37
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@igorkamyshev igorkamyshev merged commit 82363ab into master Dec 10, 2021
@igorkamyshev igorkamyshev deleted the rule-no-duplicate-on branch December 10, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rule: no-duplicate-on

2 participants

@igorkamyshev