Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event dispatching improvement #89

Merged
merged 3 commits into from Apr 13, 2015

Conversation

@sagikazarmark
Copy link
Contributor

sagikazarmark commented Apr 5, 2015

No description provided.

@sagikazarmark

This comment has been minimized.

Copy link
Contributor Author

sagikazarmark commented Apr 5, 2015

Solves #84 and #85

@egeloen

This comment has been minimized.

Copy link
Owner

egeloen commented Apr 7, 2015

I just review the PR and you do an amazing work! Defintively 👍! Just one missing thing: Can you add a note in the UPGRADE file as it is definitively a big BC break? :)

@sagikazarmark

This comment has been minimized.

Copy link
Contributor Author

sagikazarmark commented Apr 7, 2015

Sure, added it as 0.7 to 0.8

@egeloen

This comment has been minimized.

Copy link
Owner

egeloen commented Apr 13, 2015

👍 Thank you!

egeloen added a commit that referenced this pull request Apr 13, 2015
Event dispatching improvement
@egeloen egeloen merged commit 79e75ea into egeloen:master Apr 13, 2015
1 of 2 checks passed
1 of 2 checks passed
Scrutinizer Errored
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sagikazarmark

This comment has been minimized.

Copy link
Contributor Author

sagikazarmark commented Apr 13, 2015

Actually this one also closes #85 IMO

@sagikazarmark sagikazarmark deleted the sagikazarmark:event_dispatching_improvement branch Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.