Skip to content
Permalink
Browse files

Remove TCL_TRACE_READS for Tcl_TraceVar(net-type)

Patch by: michaelortmann

The concept idea was:
    - Write trace to give that warning and update the C variable.
    - Read trace to return a string to Tcl whenever the variable is read instead of the internal number.

However, existing scripts might rely on this being a number from Tcl's point of view. This is fine until we decide to change that.
  • Loading branch information
michaelortmann committed Mar 14, 2020
1 parent 6e072f0 commit 36e00f3a97435b5e82a8e3ee12775bdad355c63b
Showing with 2 additions and 2 deletions.
  1. +2 −2 src/mod/server.mod/server.c
@@ -2096,7 +2096,7 @@ static char *server_close()
TCL_TRACE_READS | TCL_TRACE_WRITES | TCL_TRACE_UNSETS,
traced_serveraddress, NULL);
Tcl_UntraceVar(interp, "net-type",
TCL_TRACE_READS | TCL_TRACE_WRITES | TCL_TRACE_UNSETS,
TCL_TRACE_WRITES | TCL_TRACE_UNSETS,
traced_nettype, NULL);
Tcl_UntraceVar(interp, "nick-len",
TCL_TRACE_READS | TCL_TRACE_WRITES | TCL_TRACE_UNSETS,
@@ -2269,7 +2269,7 @@ char *server_start(Function *global_funcs)
TCL_TRACE_READS | TCL_TRACE_WRITES | TCL_TRACE_UNSETS,
traced_serveraddress, NULL);
Tcl_TraceVar(interp, "net-type",
TCL_TRACE_READS | TCL_TRACE_WRITES | TCL_TRACE_UNSETS,
TCL_TRACE_WRITES | TCL_TRACE_UNSETS,
traced_nettype, NULL);
Tcl_TraceVar(interp, "nick-len",
TCL_TRACE_READS | TCL_TRACE_WRITES | TCL_TRACE_UNSETS,

0 comments on commit 36e00f3

Please sign in to comment.
You can’t perform that action at this time.