New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NO_OLD_BOTNET by default #430

Open
Cizzle opened this Issue Jul 22, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@Cizzle
Member

Cizzle commented Jul 22, 2017

Might be time to #define NO_OLD_BOTNET in eggdrop.h by default as this is still something from before eggdrop v1.3.
Need to precede this by double-checking no old botmessage commands are used anymore (like "error" still is).

@orkim

This comment has been minimized.

Show comment
Hide comment
@orkim

orkim Aug 8, 2017

Should the NO_OLD_BOTNET macros be removed and thus no longer support linking to pre 1.3.x bots? Or are you suggesting leaving the macros and just changing to #define NO_OLD_BOTNET by default?

orkim commented Aug 8, 2017

Should the NO_OLD_BOTNET macros be removed and thus no longer support linking to pre 1.3.x bots? Or are you suggesting leaving the macros and just changing to #define NO_OLD_BOTNET by default?

@orkim

This comment has been minimized.

Show comment
Hide comment
@orkim

orkim Aug 8, 2017

Some notes from review:

  • Looking over the C_bot[] array, the "away" entry appears to be for old bots (newer bots just use the 'i' (idle) command). However, there are no #ifndef around it (I believe it should be though).
  • Some of the code still uses "error" like you have said; it should be converted to using 'e' (which is already an entry in the array; looks like botcmd.c and dcc.c are the only 2 files).
  • The "linked" botnet message doesn't appears to only be used for old bots (It doesn't have #ifndef around it on the C_Bot[] array.)
  • All the rest of the commands surrounded with #ifndef in the C_bot[] array look like they're taken care of properly.

Hope that helps. Let me know if you would like me to take a stab at implementing it.

orkim commented Aug 8, 2017

Some notes from review:

  • Looking over the C_bot[] array, the "away" entry appears to be for old bots (newer bots just use the 'i' (idle) command). However, there are no #ifndef around it (I believe it should be though).
  • Some of the code still uses "error" like you have said; it should be converted to using 'e' (which is already an entry in the array; looks like botcmd.c and dcc.c are the only 2 files).
  • The "linked" botnet message doesn't appears to only be used for old bots (It doesn't have #ifndef around it on the C_Bot[] array.)
  • All the rest of the commands surrounded with #ifndef in the C_bot[] array look like they're taken care of properly.

Hope that helps. Let me know if you would like me to take a stab at implementing it.

@Cizzle

This comment has been minimized.

Show comment
Hide comment
@Cizzle

Cizzle Aug 9, 2017

Member

I suggest to first add the define in a future version (1.8.4? 1.9?) and then in a following version remove it altogether.

Will probably be easier to do this right with the new console logging modes added.

Member

Cizzle commented Aug 9, 2017

I suggest to first add the define in a future version (1.8.4? 1.9?) and then in a following version remove it altogether.

Will probably be easier to do this right with the new console logging modes added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment